[Bug] Line chart tiny segments skipped, becoming a slope

Open
#21,614 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
typescript

Research direction

Start with the tiny-segment handling around line 83 of src/chart/line/poly.ts and reproduce the issue using the linked CodeSandbox with step:'end'. Verify the fix against the reported datapoints and confirm that the segment from datapoint2 to datapoint3 is rendered vertically rather than as a slope.

Written by the indexing model from the issue text.

Description

bug en pending
Version

5.6.0

Link to Minimal Reproduction

https://codesandbox.io/p/sandbox/pdh82y?file=%2Findex.js

Steps to Reproduce
  1. change the time on datapoint1 from 08:59:30 to 08:55:30
  2. change the time on datapoint1 back
  3. repeat
Current Behavior

When we have the following data:

  • datapoint1=[08:59:30, 1]
  • datapoint2=[09:00:00, 1]
  • datapoint3=[09:00:00, 0]

With the following line chart setting:

  • type:'line'
  • step:'end'

The line chart ignores datapoint2 and draws a line from datapoint1 to datapoint3 which becomes a slope.

Expected Behavior

The line chart should draw the line vertically (not as a slope) from datapoint2 to datapoint3 to represent what the data is actually doing.

Environment
- OS: Windows 11
- Browser: Microsoft Edge Version 148.0.3967.54 (Official build) (64-bit)
- Framework:
Any additional comments?

The line of code that appears to be causing this behaviour is "/src/chart/line/poly.ts" at line 83. (The section for "Ignore Tiny Segment.")

            // Ignore tiny segment.
            if ((dx * dx + dy * dy) < 0.5) {
                idx += dir;
                continue;
            }
Dominant language
TypeScript
Stars
67.7k
Forks
19.9k
PR merge metrics
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from apache/echarts

All issues in apache/echarts

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.