Build fails because redundant “git.properties” definition from "pom.xml"
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- java
- Domain
- build-system
Research direction
Inspect the root pom.xml resource and exclusion configuration, then reproduce the failure with mvn clean package -DskipTests. Confirm the redundant git.properties handling is resolved and that the build completes without the NoSuchFileException.
Written by the indexing model from the issue text.
Description
Describe the bug
There are some redundant “git.properties” definition from "pom.xml" which causes build fail.
To Reproduce
-
Build the project via:
mvn clean package -DskipTests -
Build fails with below error message:
java.nio.file.NoSuchFileException: xxx\distribution..\git.properties
Expected behavior
Build should succeeds.
Drill version
1.21.2
Additional context
I've checked "pom.xml" and found the root cause of this issue:
> <configuration>
> <outputDirectory>${project.build.outputDirectory}</outputDirectory>
> <resources>
> <resource>
> <!--suppress UnresolvedMavenProperty -->
> <directory>${maven.multiModuleProjectDirectory}</directory>
> </resource>
> <include>git.properties</include>
> </resources>
> </configuration>
>
But, "git.properties" also exist on <exclude>...</exclude>definition, which causes conflict.
> <configuration>
> <excludes>
> <!-- Please keep this list sorted. -->
> <exclude>**/*.accdb</exclude>
> <exclude>**/*.access_log</exclude>
> <exclude>**/*.access_log</exclude>
> <exclude>**/.asf.yaml</exclude>
> <exclude>**/*.autotools</exclude>
> <exclude>**/*.avi</exclude>
> <exclude>**/*.avro</exclude>
> <exclude>**/.buildpath</exclude>
> <exclude>**/*.checkstyle</exclude>
> <exclude>**/.classpath</exclude>
> <exclude>**/client/*build*/**</exclude>
> <exclude>**/clientlib/y2038/*.c</exclude> <!-- All the files here should have MIT License -->
> <exclude>**/clientlib/y2038/*.h</exclude> <!-- All the files here should have MIT License -->
> <exclude>**/client/tags</exclude>
> <exclude>**/cmake_install.cmake</exclude>
> <exclude>**/*.cnf</exclude>
> <exclude>**/control</exclude>
> <exclude>**/*.cproject</exclude>
> <exclude>**/*.css</exclude>
> <exclude>**/*.csv</exclude>
> <exclude>**/*.csvh</exclude>
> <exclude>**/*.csvh-test</exclude>
> <exclude>**/*.dbf</exclude>
> <!-- TODO DRILL-4336: try to avoid the need to add this -->
> <exclude>dependency-reduced-pom.xml</exclude>
> <exclude>**/*.drill</exclude>
> <exclude>**/.drill.parquet_metadata</exclude>
> <exclude>**/*.eps</exclude>
> **<exclude>**/git.properties</exclude>**
> ...
So, it's necessary to remove the redundant “git.properties” definition from "<include>...</include>" block.
- Dominant language
- Java
- Stars
- 2k
- Forks
- 989
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 4
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/drill
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 28/100
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Similar issues
-
cbor
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
FasterXML/jackson-dataformats-binary#844 ·
Maintainers usually reply within 1 day
-
improvement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
apache/iceberg#18351 · 1 comment ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
repowise-dev/repowise#2945 · 1 comment ·
Maintainers usually reply within 1 day
-
Interpolating settings.xml can lead to malformed XML when variable value contains double-hyphenOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
apache/maven#13321 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
liquid-java/liquidjava#321 ·
Maintainers usually reply within 2 days