`verify-release-candidate.sh` version check doesn't catch `-dev` versions and is skipped on macOS
Maintainers usually reply within 1 day
@vinycalves is already working on this.
Since Nov 18, 2026.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- build-system, release
Research direction
Read dev/release/verify-release-candidate.sh around the existing Cargo.toml version check, then run the reproduction commands from the issue on GNU and BSD/macOS. Update the check to catch the stated -dev and -SNAPSHOT suffixes and work with both find implementations. Done when a pre-release version fails the check on both platforms and a release version passes.
Written by the indexing model from the issue text.
Description
Describe the bug
verify-release-candidate.sh rejects a release whose Cargo.toml contains SNAPSHOT:
The check misses a pre-release version in two ways.
First, #26845 changed main to -dev versions (57.0.0-dev today), but the check still greps for SNAPSHOT, which no Cargo.toml has used since #1350. An RC cut with a leftover -dev version passes on every platform.
Second, the check calls find without a starting path. GNU find defaults the path to ., but BSD find on macOS requires one and exits with find: illegal option -- i. That failure happens inside the if ( ... ) condition, so set -e doesn't stop the script and the condition is false. On macOS the check passes without reading any Cargo.toml.
To Reproduce
On macOS:
$ if ( /usr/bin/find -iname 'Cargo.toml' | xargs grep SNAPSHOT ); then echo found; else echo "check passed"; fi
/usr/bin/find: illegal option -- i
check passed
On any platform, from a main checkout:
$ if ( find . -iname 'Cargo.toml' | xargs grep SNAPSHOT ); then echo found; else echo "check passed"; fi
check passed
$ grep -m1 '^version' Cargo.toml
version = "57.0.0-dev"
I found this while verifying 56.0.0-rc2. A manual grep for -dev and -SNAPSHOT versions found none in that release.
Expected behavior
The check fails for any pre-release version suffix, on both GNU and BSD find. For example:
if ( find . -name 'Cargo.toml' -print0 | xargs -0 grep -nE '^version *= *"[^"]*-(dev|SNAPSHOT)' ); then
echo "Cargo.toml version should not have a -dev or -SNAPSHOT suffix for releases"
exit 1
fi
- Dominant language
- Rust
- Stars
- 9.6k
- Forks
- 2.6k
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 352
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/datafusion
-
`MoveTowardsLeafNodes` placement implies speculative evaluation, but the docs don't say soPossibly taken @Inf1mum claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
apache/datafusion#27487 · 3 comments ·
Maintainers usually reply within 1 day
-
`lpad` and `rpad` with a literal length above `i32::MAX` error on a NULL string or fillPossibly taken @TechWizard9999 claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
apache/datafusion#27482 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
Window constructors panic when the expression list is emptyPossibly taken @abp002 claimed this 4 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
apache/datafusion#27315 · 3 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
apache/datafusion#27094 · 1 comment ·
Maintainers usually reply within 1 day
-
Substrait consumer doesn't recognise `shift_left` / `shift_right` from functions_arithmetic.yamlPossibly taken @jonasHanhan claimed this 14 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
apache/datafusion#27059 ·
Maintainers usually reply within 1 day
All issues in apache/datafusion
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
tinystream-dev/tinystream#132 ·
-
contract good first issue testing
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Emmyt24/nova-launch#2436 ·
Maintainers usually reply within 1 day