Mark generated files as linguist-generated
Nobody has claimed this yet.
- #205 by @ump45nose — closed without merging
Assessment
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 85/100
Research direction
Add the three patterns from the issue to a .gitattributes file at the repository root, each with linguist-generated=true. Read the existing repository attributes first, if present, and confirm the patterns match the generated Swift files named in the issue. Done when GitHub Linguist treats those files as generated.
Written by the indexing model from the issue text.
Description
Describe the enhancement requested
We commit generated source files to this repository:
- FlatBuffers:
Sources/Arrow/*_generated.swift - Protocol Buffers/gRPC:
Sources/ArrowFlight/*.pb.swiftandSources/ArrowFlight/*.grpc.swift
When these files are regenerated, for example on a FlatBuffers or gRPC Swift upgrade such as #201 and #202, their changes dominate the PR diff. This makes the hand-written changes harder to review.
GitHub doesn't detect these files as generated automatically because they start with the ASF license header.
How about adding a .gitattributes that marks them as linguist-generated? GitHub collapses diffs of such files in PRs by default, and they can still be expanded when needed:
Sources/Arrow/*_generated.swift linguist-generated=true
Sources/ArrowFlight/*.pb.swift linguist-generated=true
Sources/ArrowFlight/*.grpc.swift linguist-generated=true
- Dominant language
- Swift
- Stars
- 33
- Forks
- 18
- Avg merge
- 1h 38m
- Merged PRs (30d)
- 4
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/arrow-swift
-
setup-swift doesn't work on Ubuntu 26.04Possibly taken @ump45nose claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
apache/arrow-swift#199 ·
-
BaseBufferBuilder.isNull returns the inverse of the null statePossibly taken @maltzsama claimed this 97 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
apache/arrow-swift#180 ·
-
ArrowReader.fromFile crashes on files smaller than the Arrow file markerPossibly taken @maltzsama claimed this 97 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
apache/arrow-swift#176 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
apache/arrow-swift#204 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
apache/arrow-swift#186 ·
All issues in apache/arrow-swift
Similar issues
-
Seed a JRNYAx price before the last close so asset-detail S1.3 doesn't fail from 08:00Z to the openOpenbug tests
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
lognorman20/monaco#7231 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 5 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Provenance-Emu/SkinKit#42 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
lwouis/alt-tab-macos#6154 ·
-
bug mac アプリ: コード アプリ: チャット 優先: 中 要トリアージ
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
yksr-melt/Meltype#1346 · 2 comments ·
Maintainers usually reply within 1 day