dev/release: verify-release-candidate.sh runs 0 Java tests with Debian's Maven
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- java
- Domain
- build-system, testing
Research direction
Start by reading dev/release/verify/java/pom.xml and the Java verification steps in dev/release/verify-release-candidate.sh. Reproduce with TEST_DEFAULT=0 TEST_JARS=1 dev/release/verify-release-candidate.sh 25 2 using Debian's Maven, then check that the JUnit 5 tests in VerifyReleaseCandidateTest actually run and that zero tests causes verification to fail.
Written by the indexing model from the issue text.
Description
What happened?
TEST_JARS=1 dev/release/verify-release-candidate.sh reports success, but no Java tests actually run:
[INFO] --- surefire:2.17:test (default-test) @ adbc-java-verification ---
...
Results :
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
[INFO] BUILD SUCCESS
...
Release candidate looks good!
dev/release/verify/java/pom.xml doesn't pin maven-surefire-plugin, so the version comes from Maven's default lifecycle bindings. Upstream Maven 3.9.12 uses surefire 3.2.5. Debian's maven package (3.9.12-1) changes the default to surefire 2.17 with debian/patches/default-bindings.patch:
https://sources.debian.org/src/maven/3.9.12-1/debian/patches/default-bindings.patch/
Surefire 2.17 doesn't support the JUnit Platform, so it falls back to the JUnit 3 provider and doesn't find the JUnit 5 tests in VerifyReleaseCandidateTest. Because zero tests isn't treated as a failure, the Java JAR verification passes without checking anything.
Stack Trace
No response
How can we reproduce the bug?
Reproduced with:
- Debian/Ubuntu
mavenpackage 3.9.12 TEST_DEFAULT=0 TEST_JARS=1 dev/release/verify-release-candidate.sh 25 2
Environment/Setup
No response
- Dominant language
- C#
- Stars
- 636
- Forks
- 236
- Avg merge
- 1d 1h
- Merged PRs (30d)
- 98
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/arrow-adbc
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
apache/arrow-adbc#4915 · 1 comment ·
Maintainers usually reply within 1 day
-
go: some option constants are named wronglyMay be free again @aryan9948 claimed this 18 days ago, and no pull request is open. OpenType: enhancement
Difficulty 1/5 Under an hour Newbie friendliness 90/100
apache/arrow-adbc#4818 · 4 comments ·
Maintainers usually reply within 1 day
-
Type: enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
apache/arrow-adbc#4809 · 3 comments ·
Maintainers usually reply within 1 day
-
c/driver/postgresql: make connection init/release thread safePossibly taken @jtanx claimed this 2 days ago. OpenType: enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
apache/arrow-adbc#4753 ·
Maintainers usually reply within 1 day
-
Type: enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
apache/arrow-adbc#4375 ·
Maintainers usually reply within 1 day
All issues in apache/arrow-adbc
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
microsoft/fluentui-blazor#5535 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 74/100
AvaloniaUI/Avalonia#22582 ·
Maintainers usually reply within 2 days
-
:watch: Not Triaged CAC
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
dotnet/AspNetCore.Docs#38001 ·
Maintainers usually reply within 1 day
-
HTTP logging truncates catch-all route parameters in the formatted request pathPossibly taken @johnkaram02 claimed this today. Openarea-telemetry untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
dotnet/extensions#7883 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Nimblesite/lspkit#24 ·
Maintainers usually reply within 1 day