CLI doesn't allow custom builder to pass additional extensions when building app for i18n extractions
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- angular, typescript
- Domain
- build-system, cli, internationalization
Research direction
Start in packages/angular_devkit/build_angular/src/builders/extract-i18n/application-extraction.ts at the linked line and compare how regular application builds receive extensions. Verify that extract-i18n passes custom builder extensions during application compilation and that messages.xlf contains the extracted messages rather than being empty.
Written by the indexing model from the issue text.
Description
Command
extract-i18n
Description
We're in the process of migrating from webpack to esbuild.
To provide custom esbuild plugins we decided to use custom builder (https://github.com/just-jeb/angular-builders).
It went smooth until we realised that extract-i18 no longer works. It ends successfully but messages.xlf is empty.
It turned out that angular checks builderName to choose which bundler to use.
To fix that I decided to implement custom extract-i18n builder that will trick angular/cli and force using esbuild -
https://github.com/just-jeb/angular-builders/pull/1711
For the record nrwl/nx did the same - https://github.com/nrwl/nx/pull/21802
The issue is that angular/cli will not let us pass any extensions during i18n application compilation.
It may lead to inconsistency between build and extract flow, which I suppose may lead to issues with i18n.
Describe the solution you'd like
We should be able to pass custom extensions as for regular app building.
(bonus) would be really nice if these if (builderName === ... are replaced by something that is custom builder friendly 🙏
Describe alternatives you've considered
Alternatively we could rewrite whole extract-i18n builder, but as 95% of the code would be the same - it seems pointless
- Dominant language
- TypeScript
- Stars
- 27k
- Forks
- 11.8k
- Avg merge
- 16h 35m
- Merged PRs (30d)
- 176
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from angular/angular-cli
-
area: @angular/build gemini-triaged
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
angular/angular-cli#33955 ·
-
area: @angular/cli gemini-triaged
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
angular/angular-cli#33055 · 1 comment · 3 reactions ·
-
area: @angular/build gemini-triaged
Difficulty 4/5 3-5 days Newbie friendliness 72/100
angular/angular-cli#34137 ·
-
angular/build:library area: @angular/build gemini-triaged
angular/angular-cli#34131 · 1 assignee ·
-
angular/build:library area: @angular/build gemini-triaged
angular/angular-cli#34130 · 1 assignee ·
All issues in angular/angular-cli
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ontola/atomic-server#1625 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
melgarafael/DeskcommCRM#1451 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
-
bug via-triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
bot:ai-assisted component:compact-js status:untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
midnightntwrk/midnight-sdk#403 ·