extract-i18n does not extract message from files loaded only server side

Open
#22,871 7 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
angular, typescript
Domain
localization, tooling

Research direction

Run extract-i18n in the linked repro app and compare its output with the message in server-service.service.ts. Trace how the command discovers files that are not directly dependent on app.module or the browser-side code. Done means messages from the server-side service are included in extraction output.

Written by the indexing model from the issue text.

Description

area: @angular-devkit/build-angular devkit/build-angular:i18n feature feature: insufficient votes

🐞 Bug report

Command (mark with an x)
  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • [x ] extract-i18n
  • run
  • config
  • help
  • version
  • doc
Is this a regression?
Yes, the previous version in which this bug was not present was: ....
Description

The extraction tool does not process files that do not have a direct dependency on the app.module, or, generally, on the browser side.
In my case an abstract service is replaced by two versions of the service, one browser side, the other server side. The server-side one is ignored during the extraction process.

🔬 Minimal Reproduction

I made a simple repro app that reproduce the problem.
Just run extract-i18n to see that message in server-service.service.ts is ignored.

🔥 Exception or Error

🌍 Your Environment




Angular: 12.0.1
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, language-service, material, platform-browser
... platform-browser-dynamic, platform-server, router
... service-worker

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.1200.5
@angular-devkit/build-angular     12.0.5
@angular-devkit/build-optimizer   0.1200.5
@angular-devkit/core              12.0.1
@angular-devkit/schematics        12.0.1
@angular/flex-layout              12.0.0-beta.34
@angular/localize                 12.0.5
@nguniversal/builders             12.1.3
@nguniversal/common               12.0.0
@nguniversal/express-engine       12.0.0
@schematics/angular               12.0.1
rxjs                              7.4.0
typescript                        4.2.4

Anything else relevant?

Dominant language
TypeScript
Stars
27k
Forks
11.8k
Avg merge
16h 35m
Merged PRs (30d)
176

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from angular/angular-cli

All issues in angular/angular-cli

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.