Rotate and stdin set drop trailing newlines

Open Beginner friendly
  • Is something wrong?
#35 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
66/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
bash
Domain
cli, security

Research direction

The three affected spots are bin/xenv around lines 1891, 1972 and 2028, where rotate and stdin set capture plaintext with command substitution. Read cmd_get first, since it already keeps plaintext in a file, and compare how it differs from the rotate and set paths. Reproduce with printf 'hello\n\n' piped into xenv set, then xenv get, and confirm the trailing newlines are lost. Done means the round trip preserves trailing newlines for set and rotate.

Written by the indexing model from the issue text.

Description

bug

Files: bin/xenv:1891, bin/xenv:1972, bin/xenv:2028

Reproduced. Repro: printf 'hello\n\n' | xenv set @dev KEY, then xenv get @dev KEY. The stored value is hello. Rotate does the same via plain=$(decrypt). get already avoids $() for this reason.

Fix: Keep plaintext in a file, the way cmd_get does. Do not capture it with command substitution.

Found at 6e8d2b4 by three runs of a whole-repo review team (deploystrata/offload), then hand-checked against the code by Grok. Lines marked Reproduced were also run by Claude.

Dominant language
Shell
Stars
8
Forks
0
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ahoward/xenv

All issues in ahoward/xenv

Similar issues

More Shell/Bash issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.