Recipe atomic writes share one temp file per key

Open
  • Is something wrong?
#33 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp, elixir, go, java, javascript, python, ruby, rust, shell
Domain
security

Research direction

The race is in the atomic-write block of each language writer: recipes/csharp/Program.cs:211, recipes/elixir/xenv.exs:219, recipes/go/xenv/xenv.go:286, recipes/java/Xenv.java:237, recipes/node/xenv.js:166, recipes/pythong/xenv.py:178, recipes/ruby/xenv.rb:161 and recipes/rust/src/lib.rs:391. Start with bin/xenv's .tmp.$$ approach as the reference, then decide with maintainers whether to fix all eight writers or wait for #16 to delete them. Done means unique O_EXCL temp names in each writer and no shared <key>.value.enc.tmp path left.

Written by the indexing model from the issue text.

Description

bug

Files: recipes/csharp/Program.cs:211; recipes/elixir/xenv.exs:219; recipes/go/xenv/xenv.go:286; recipes/java/Xenv.java:237; recipes/node/xenv.js:166; recipes/pythong/xenv.py:178; recipes/ruby/xenv.rb:161; recipes/rust/src/lib.rs:391

Repro: Two processes call set on the same key. Both truncate .value.enc.tmp. One rename leaves a torn or swapped envelope. If that path is a symlink, Go and Node write the target.

Fix: Use a unique temp name and O_EXCL, as bin/xenv does with .tmp.$$. #16 deletes these writers. Until then the race is live.

Found at 6e8d2b4 by three runs of a whole-repo review team (deploystrata/offload), then hand-checked against the code by Grok. Lines marked Reproduced were also run by Claude.

Dominant language
Shell
Stars
8
Forks
0
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ahoward/xenv

All issues in ahoward/xenv

Similar issues

More Shell/Bash issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.