Close the initial GCS range reader when closing rangedReader
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 84/100
Research direction
Start in pkg/objectstorage/gcsranged.go, following GetObject into newRangedReader and rangedReader.Close. Check how the initial GCS range reader is passed as head and how the child context is cancelled. Done means closing a partially consumed rangedReader also closes head or otherwise stops its request, without changing later range-fetch behavior.
Written by the indexing model from the issue text.
Description
In pkg/objectstorage/gcsranged.go, GetObject opens the first GCS range reader with the caller's context and passes it as head to newRangedReader. newRangedReader creates a child context for later range fetches, but rangedReader.Close only cancels that child context and does not close head. Closing a partially consumed object reader therefore leaves the original head request/body owned by the caller's context instead of stopping it with the returned reader. Please close head on Close (or create it with the reader-owned context and still close it).
- Dominant language
- Go
- Stars
- 4.4k
- Forks
- 515
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 279
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from agent-substrate/substrate
-
area/security
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
agent-substrate/substrate#2276 ·
Maintainers usually reply within 1 day
-
Micro-VM guests unconditionally boot with root debug console on vsock 1026Possibly taken A pull request linked to this issue is open or already merged. Openarea/security
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
agent-substrate/substrate#2274 ·
Maintainers usually reply within 1 day
-
area/network kind/bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
agent-substrate/substrate#2245 ·
Maintainers usually reply within 1 day
-
[Bug]: e2e script flag parsing is brokenPossibly taken @ericcurtin claimed this 1 day ago. Openarea/dev-infra area/tests kind/bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
agent-substrate/substrate#2217 · 1 comment ·
Maintainers usually reply within 1 day
-
Reject trailing YAML documents in actor-template create manifestsPossibly taken @ericcurtin claimed this 4 days ago. Openarea/cli kind/bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
agent-substrate/substrate#2156 · 1 comment ·
Maintainers usually reply within 1 day
All issues in agent-substrate/substrate
Similar issues
-
L: github:actions L: php:composer
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
dependabot/dependabot-core#16493 ·
Maintainers usually reply within 1 day
-
Controller pods on default limits CrashLoopBackOff and constantly reclaim memoryPossibly taken @brsmnv claimed this today. Openbug
Difficulty 2/5 Under an hour Newbie friendliness 68/100
ironcore-dev/ironcore-net#560 ·
Maintainers usually reply within 1 day
-
3 registry records that cannot resolve for any client, and a caution about single-pass dead countsOpen
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
modelcontextprotocol/registry#1692 ·
Maintainers usually reply within 6 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
mark3labs/mcp-go#1039 · 1 comment ·
Maintainers usually reply within 8 days