"Register a Primitive" example declares extendDeep but doesn't use it?

Open
#2 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
45/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Stale
Tech stack
html, javascript
Domain
documentation

Research direction

Start with the linked “Register a Primitive” example and inspect the corresponding source in this generated documentation repository. Check whether the extendDeep declaration is referenced; done means the example contains no unused declaration and remains accurate when followed.

Written by the indexing model from the issue text.

Description

Following this example:
https://aframe.io/docs/0.3.0/primitives/#register-a-primitive
The first line declares var extendDeep = AFRAME.utils.extendDeep;, but it does not appear to be used in the subsequent code (the registerPrimitive line just uses extend)?

Dominant language
HTML
Stars
10
Forks
17
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aframevr/aframevr.github.io

All issues in aframevr/aframevr.github.io

Similar issues

More Documentation issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.