S2 Legend: doesn't dim on line popover selection when animations are off
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 84/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- react, typescript
- Domain
- data-visualization, frontend
Research direction
Start in legendUtils.ts at getOpacityEncoding and trace how selection rules are added for legend-level versus mark-level ChartPopover components. Reproduce the provided chart with animations disabled, then verify that non-selected legend entries dim while a mark popover is open and that existing animated behavior remains unchanged.
Written by the indexing model from the issue text.
Description
With animations={false}, selecting a line point (opening a ChartPopover) doesn't dim the other series' legend entries. With animations on, the legend dims to match the line.
Repro
<Chart data={data} animations={false}>
<Line color="series"><ChartPopover /></Line>
<Legend />
</Chart>
Click a point in series A: series B's line dims, its legend entry doesn't.
Expected
Legend entries for non-selected series dim while the popover is open.
Cause
getOpacityEncoding (legendUtils.ts) only adds the selection rule when the legend itself has chartPopovers. Mark-level popovers aren't considered.
- Dominant language
- TypeScript
- Stars
- 130
- Forks
- 30
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 91
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from adobe/react-spectrum-charts
-
bug rsc:Legend rsc:Line rsc:TrendLine s2
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
adobe/react-spectrum-charts#1075 ·
Maintainers usually reply within 1 day
-
bug rsc:Bar s2
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
adobe/react-spectrum-charts#1029 ·
Maintainers usually reply within 1 day
-
bug rsc:Legend s2
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
adobe/react-spectrum-charts#960 ·
Maintainers usually reply within 1 day
-
S2 Line: static points don't dim for highlightedItem or popover selection when animations are offOpenbug rsc:Line s2
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
adobe/react-spectrum-charts#959 ·
Maintainers usually reply within 1 day
-
S2 Line: highlightedItem on a non-interactive line throws "Unrecognized signal name"Possibly taken @Hashim1999164 claimed this 32 days ago. Openbug rsc:Line s2
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
adobe/react-spectrum-charts#958 ·
Maintainers usually reply within 1 day
All issues in adobe/react-spectrum-charts
Similar issues
-
area: frontend priority: normal
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
formbricks/formbricks#9918 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
thecodacus/pithagoras#364 ·
Maintainers usually reply within 1 day
-
TestAutonomousStop_ReportsObservedState fails under host load: 1s wall-clock ceiling vs 250ms cycleOpentype:bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
nightgauge/nightgauge#2909 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day