[ew] refactor: Version compare save function should use cavnas bus
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 69/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- javascript
- Domain
- frontend
Research direction
The issue points to PR #1478 for the new canvasBus.editorSaveRequest event and shows the existing comparisonRequest save call. Read that change first, then find the version compare save function that emits the shown saveDocument action. Switch it to the new save request and verify version comparison still saves the document.
Written by the indexing model from the issue text.
Description
https://github.com/adobe/da-live/pull/1478 adds a new canvas bus for saving through canvasBus.editorSaveRequest.emit();
We should use that instead of
canvasBus.comparisonRequest.emit({
action: 'saveDocument',
context: { org, site, path: segments.join('/') },
resolve,
});
- Dominant language
- JavaScript
- Stars
- 36
- Forks
- 74
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 49
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from adobe/da-live
-
customer-feedback ew
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
ew
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
bug ew
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
ew
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
Similar issues
-
[guide] AGENTS.md claims the coverage gate, e2e and full lint run on every PR after ADR 0011 focused validationPossibly taken @hivecommons-hive claimed this today. Openagent/guide documentation hive/claimed-by-guide stage/040-covered-by-pr
Difficulty 2/5 1-3 hours Newbie friendliness 81/100
cncf/endusers#2006 · 1 comment ·
Maintainers usually reply within 1 day
-
check:passed feeds:add
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
all-contributors/cli#587 ·
Maintainers usually reply within 1 day
-
RGAA5
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 8 days
-
feedback simulation workshop
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
githubnext/gh-aw-workshop#5157 ·
Maintainers usually reply within 1 day