feat(adcp): flag required string constraints that Go zero values violate
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start by reading the schema drift linter rule and its tests, then inspect the schema constraints for required string fields such as minLength and pattern. Add coverage for cases where the empty string is invalid and confirm the linter flags them. The issue leaves the suggested Go shape and any constructor or validation support dependent on field semantics.
Written by the indexing model from the issue text.
Description
The schema drift linter now catches required fields with omitempty, which fixed AccountSetup.Message in PR #269. It does not yet catch required string fields whose Go zero value is still schema-invalid, such as an upstream minLength: 1 or restrictive pattern.
Add a lint rule that flags required string fields when the schema makes the empty string invalid. Depending on the field semantics, the suggested Go shape may need to become *string or the SDK may need constructor/validation support.
Context: Argus follow-up on PR #269.
- Dominant language
- Go
- Stars
- 4
- Forks
- 2
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 15
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from adcontextprotocol/adcp-go
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
adcontextprotocol/adcp-go#567 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
adcontextprotocol/adcp-go#570 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 22/100
adcontextprotocol/adcp-go#564 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 8/100
adcontextprotocol/adcp-go#556 ·
Maintainers usually reply within 1 day
-
claude-triaged cross-repo
Difficulty 5/5 Over a week Newbie friendliness 25/100
adcontextprotocol/adcp-go#548 · 2 comments ·
Maintainers usually reply within 1 day
All issues in adcontextprotocol/adcp-go
Similar issues
-
effort:high model:sonnet phase:3 type:docs
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
OffchainLabs/nitro#4771 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
BurntSushi/toml#530 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 7 days