Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

support manager domain fallback

Open
  • Is something wrong?
#116 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
57/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Quiet
Tech stack
go
Domain
backend

Research direction

Start with the validate_adagents path and the AdAgentsValidationResult definition; the issue does not name specific files or tests. Trace the existing direct and URL-reference discovery paths, then add the one-hop ads.txt MANAGERDOMAIN fallback and cover the listed cases. Done means the discovery fields are exposed and all six specified behaviors are tested.

Written by the indexing model from the issue text.

Description

claude-triaged

Background

(RFC 4175) merged the ads.txt MANAGERDOMAIN fallback for adagents.json discovery into the spec and adcp repo. The validator now:

  • Attempts /{publisher}/.well-known/adagents.json first
  • On 404, consults /{publisher}/ads.txt for a MANAGERDOMAIN= directive
  • If found, attempts /{manager}/.well-known/adagents.json
  • Surfaces discovery_method: 'direct' | 'authoritative_location' | 'ads_txt_managerdomain' (required) and manager_domain?: string on AdAgentsValidationResult

adcp-go needs to implement this fallback logic and expose the new fields.

Implementation

  • Implement the one-hop ads.txt MANAGERDOMAIN fallback in the validate_adagents path
  • Add discovery_method: DiscoveryMethod (required, defaults to 'direct') and manager_domain?: string to AdAgentsValidationResult
  • Export DiscoveryMethod type
  • MANAGERDOMAIN= directive form only — comment form (# managerdomain=) must be rejected
  • Ambiguous/duplicate MANAGERDOMAIN lines: last-wins (IAB-aligned per #4173 resolution)
  • Manager domain 404 → terminal failure (not silent pass)

Test coverage

  • Direct path sets discovery_method: 'direct'
  • URL-reference path sets discovery_method: 'authoritative_location'
  • Manager domain path sets discovery_method: 'ads_txt_managerdomain' and populates manager_domain
  • Comment-form # managerdomain= is NOT followed
  • Duplicate MANAGERDOMAIN lines → last entry wins
  • Manager domain 404 → validation failure

Refs: adcontextprotocol/adcp#4173, adcontextprotocol/adcp#4175

Dominant language
Go
Stars
4
Forks
2
Avg merge
13h 10m
Merged PRs (30d)
20

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from adcontextprotocol/adcp-go

All issues in adcontextprotocol/adcp-go

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.