@actions/cache: downloadCacheHttpClientConcurrent never stops its progress timer on failure, so the step hangs until the job times out
Maintainers usually reply within 1 day
@YodHeVauHe is already working on this.
Since Oct 4, 2026.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- tooling
Research direction
Start in packages/cache/src/internal/downloadUtils.ts, reading downloadCacheHttpClientConcurrent around the progress timer and its finally block; compare its cleanup with downloadCacheStorageSDK. Run the provided npm and repro.mjs commands, then confirm that a rejected download stops progress output and lets the process exit.
Written by the indexing model from the issue text.
Description
Describe the bug
When downloadCacheHttpClientConcurrent throws, it never stops its DownloadProgress display timer. The timer reschedules itself every second until isDone(), which a failed download never reaches. So Node's event loop never empties, the calling action finishes its work, and the step prints Received 0 of N (0.0%), 0.0 MBs/sec until the job times out or someone cancels it.
The timer starts here:
This is the only cleanup, and it doesn't touch progress:
The timer re-arms itself on every tick until the download completes:
downloadCacheStorageSDK already stops its timer in finally:
This is related to #2470 but has a different cause. #2470 is the promiseWithTimeout timer, which holds the process for at most 10 minutes. This timer has no upper bound, and #2478 doesn't change it.
Observed in CI
actions/setup-node@v7 (bundles @actions/cache 6.1.0) and tailscale/github-action v4.2.0 (bundles 5.0.2), on third-party runners (Ubicloud). Each 4 MiB ranged GET got a 161-byte body back, so the first archiveDescriptor.write threw. The action logged the warning and carried on, but the step never exited.
setup-node: the step logged the failure and moved on, then kept printing progress for 15 minutes until the job timeout:
10:58:59.536 /home/runner/.pnpm-store/v11
10:59:00.391 ##[warning]Failed to restore: The value of "length" is out of range. It must be <= 161. Received 4194304
10:59:00.404 pnpm cache is not found
10:59:00.793 Received 58720256 of 436400958 (13.5%), 55.9 MBs/sec
... (the same byte count, once a second)
11:13:46.847 Received 58720256 of 436400958 (13.5%), 0.1 MBs/sec
11:13:46.919 ##[error]The operation was canceled.
tailscale: the action fell back to a direct download, joined the tailnet and finished at 12:24:50. The step then printed progress until the 5-minute step timeout:
12:24:45.188 ##[warning]Failed to restore: The value of "length" is out of range. It must be <= 161. Received 4194304
12:24:46.005 Received 0 of 34760007 (0.0%), 0.0 MBs/sec
12:24:50.613 Ping host ... reachable via direct connection!
... (Received 0 of 34760007, once a second)
12:29:44.556 ##[error]The action 'Join tailnet' has timed out after 5 minutes.
Another job without a step timeout stayed in Setup Node.js for over an hour before it was cancelled.
The trigger here was a misbehaving cache backend, which I'm raising with the provider separately. The hang doesn't depend on the trigger: any rejection inside the try block, including a failed write, a failed segment or a HEAD without Content-Length after the timer started, leaves the timer running.
To Reproduce
This uses the published 6.3.0 package against a local server that answers every ranged GET with a short 200:
npm i @actions/[email protected]
timeout 300 node repro.mjs; echo "exit=$?"
// repro.mjs
import http from 'node:http';
import os from 'node:os';
import path from 'node:path';
import { downloadCacheHttpClientConcurrent } from './node_modules/@actions/cache/lib/internal/downloadUtils.js';
const LENGTH = 34760007;
const server = http.createServer((req, res) => {
if (req.method === 'HEAD') {
res.writeHead(200, { 'Content-Length': LENGTH });
return res.end();
}
res.writeHead(200, { 'Content-Type': 'application/json' });
res.end(JSON.stringify({ error: 'x'.repeat(161 - 12) }));
});
await new Promise((r) => server.listen(0, '127.0.0.1', r));
const url = `http://127.0.0.1:${server.address().port}/cache.tzst`;
try {
await downloadCacheHttpClientConcurrent(url, path.join(os.tmpdir(), 'repro.tzst'), {
timeoutInMs: 30000,
downloadConcurrency: 8,
});
} catch (error) {
console.log(`rejected: ${error.message}`);
}
server.close();
console.log('download settled, server closed');
Output on Node 24.18.0:
rejected: The value of "length" is out of range. It must be <= 161. Received 4194304
download settled, server closed
Received 0 of 34760007 (0.0%), 0.0 MBs/sec
Received 0 of 34760007 (0.0%), 0.0 MBs/sec
...
exit=124
In this run it printed 299 progress lines after the rejection before timeout killed it at 300 s.
Expected behavior
Once the download settles, whether it succeeded or failed, the display timer stops and the process can exit.
Suggested fix
Hoist progress out of the try and stop it in finally, as downloadCacheStorageSDK already does:
const archiveDescriptor = await fs.promises.open(archivePath, 'w')
const httpClient = new HttpClient('actions/cache', undefined, {
socketTimeout: options.timeoutInMs,
keepAlive: true
})
+ let progress: DownloadProgress | undefined
try {
...
- const progress = new DownloadProgress(length)
+ progress = new DownloadProgress(length)
progress.startDisplayTimer()
...
} finally {
+ progress?.stopDisplayTimer()
httpClient.dispose()
await archiveDescriptor.close()
}
I applied the equivalent change to the compiled 6.3.0 output and ran the repro against it:
| Build | Process exits after the download rejects |
|---|---|
| 6.3.0 as published | never (killed at 300 s) |
| + the change above | 80 s |
| + the change above and #2478 | 61 s |
What keeps the process alive for the remaining ~60 s: segment downloads that were already in flight when the write threw keep retrying (downloadSegmentRetry, 5 retries, each with a 5 s retryHttpClientResponse backoff). Each attempt fails with Client has already been disposed. Nothing cancels them when the download is abandoned. That's secondary, bounded, and probably worth its own change. The display timer is the part that never ends.
Additional context
@actions/cache6.3.0 is affected, and so ismainat85d7331. So are the copies bundled inactions/setup-node@v7(6.1.0) andtailscale/github-actionv4.2.0 (5.0.2).- Linux, Node 24.
- This path is used only when the archive hostname ends in
.blob.core.windows.net(see #2487).
- Dominant language
- TypeScript
- Stars
- 5.9k
- Forks
- 1.8k
- Avg merge
- 15m
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from actions/toolkit
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
@actions/io: `mv(file, dest)` replaces `dest` when it is a symlink to a directory instead of moving into itPossibly taken @bardrop claimed this 7 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
@actions/exec: `exec(commandLine)` drops `""` arguments and trims trailing spaces of the last argumentPossibly taken @bardrop claimed this 7 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
actions/toolkit#2565 · 1 comment ·
Maintainers usually reply within 1 day
Similar issues
-
db-d1-sqlite: upsert is aliased to updateOne, so payload.kv.set never inserts new keysPossibly taken @pcbeingused333 claimed this today. OpenBug db: d1-sqlite Payload OSS
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
payloadcms/payload#19766 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
device-management-toolkit/sample-web-ui#3711 ·
Maintainers usually reply within 1 day
-
bug impact:low Team: SecuritySolution Team:Defend Workflows v9.6.0
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
elastic/kibana#306401 · 3 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
agentes-chat/agentes-chat#927 ·
Maintainers usually reply within 1 day
-
Closing a pinned tab jumps to the Tabs section instead of the next open pinned tabPossibly taken @seenimohamed claimed this today. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ardia-browser/ardia#2769 ·
Maintainers usually reply within 1 day