[Feature Request] Do not close PRs that have auto-merge activated
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- github-actions, typescript
Research direction
Start by tracing the stale bot's pull-request closing path and how it could detect whether auto-merge is enabled; the issue names no file or test entry point. Done means an auto-merge-enabled PR remains open and receives the proposed explanatory comment, while ordinary stale PR behavior is preserved.
Written by the indexing model from the issue text.
Description
Description:
If a PR is enabled for auto-merge, then stale bot should never close the PR. Stale bot could add a comment to the PR saying that the PR is stuck in the auto-merge process.
Justification:
Auto-merge is a convenient feature to merge PRs without waiting for the completion of a long CI run. However, if a CI test fails unexpectedly (e.g. because of flakiness), then the PR would never turn green and consequently auto-merge would not perform the merge. After some time the stale action would close the PR.
However, I believe PRs that have auto-merge activated should never be closed automatically because there was already a serious intention to merge the PR.
/cc @leonor-loureiro @dkunkler
- Dominant language
- TypeScript
- Stars
- 1.7k
- Forks
- 438
- Avg merge
- 27d 8h
- Merged PRs (30d)
- 1
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from actions/stale
-
Stale label remains after pushing a new commitPossibly taken @v-chiranjib-swain claimed this 21 days ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 52/100
-
Closing items while paginating can skip open pull requestsPossibly taken @v-chiranjib-swain claimed this 93 days ago. Openbug
-
Ignore issues which has linked open PRsPossibly taken A pull request linked to this issue is open or already merged. Openfeature request
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
feature request
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
solidjs/solid-docs#1716 ·
Maintainers usually reply within 1 day
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Progress indicated by console logs is off by onePossibly taken @marceliwac claimed this today. Openbug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
aws-samples/aws-cdk-examples#1336 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
melgarafael/DeskcommCRM#4999 · 1 comment ·
Maintainers usually reply within 1 day
-
type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days