Annotation matcher can not match column ranges

Open
#475 4 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 5 days

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
github-actions
Domain
ci-cd

Research direction

Start with matchers.json and inspect the annotation matcher regex against the gopls output shown in the linked sample run. Verify that column ranges containing a hyphen are detected as error annotations, while existing lines without a hyphen continue to match.

Written by the indexing model from the issue text.

Description

feature request

Description:
Tools like gopls check <files> can output line column ranges but the matcher installed by this action can not match them.

This action can not match these column ranges because the - character is not included in the regex ^\\s*(.+\\.go):(?:(\\d+):(\\d+):)? (.*). All such lines in this sample run should trigger a error annotation, but currently ones ones without a - trigger it:

image

Action version:
v5.0.0

Platform:
all

Runner type:
all

Tools version:
all

Repro steps:
https://github.com/go-gitea/gitea/actions/runs/8883003671/job/24388906594

Expected behavior:
Lines with - in the column field to be detected as error annotation.

Actual behavior:
Only lines without - in the column are detected as error annotation.

Dominant language
TypeScript
Stars
1.8k
Forks
684
Avg merge
12d 23h
Merged PRs (30d)
3

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from actions/setup-go

All issues in actions/setup-go

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.