Remove world writable from install-dotnet.sh

Open
#659 1 comment 2 reactions 0 assignees View on GitHub

Maintainers usually reply within 7 days

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
55/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
typescript
Domain
devops

Research direction

Start at src/installer.ts#L171, where install-dotnet.sh is created. Verify the current file permissions and update them from 777 to 775. Done means the generated script is no longer world-writable and vulnerability scans no longer report the issue.

Written by the indexing model from the issue text.

Description

feature request

Description:
The script install-dotnet.sh is created on the following line:
https://github.com/actions/setup-dotnet/blob/main/src/installer.ts#L171

This creates a file on the filesystem with chmod 777 set making it world writable and triggering vulnerability scans. I would like to propose changing this to 775.

Justification:
To close open vulnerabilities for files with world writable permissions in directories that don't have a sticky bit set, update the permissions of install-dotnet.sh to 775.

Are you willing to submit a PR?
Yes I am willing to submit a PR.

Dominant language
TypeScript
Stars
1.2k
Forks
579
Avg merge
6d 4h
Merged PRs (30d)
1

Getting set up

  • No Dockerfile or Docker Compose file
  • Has a pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from actions/setup-dotnet

All issues in actions/setup-dotnet

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.