Sync-labels should not remove an unspecified label
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- github-actions, typescript
- Domain
- ci-cd
Research direction
Start by locating the handling for sync-labels: true and the labeler.yml label definitions, then inspect any nearby tests for label synchronization. Done means labels absent from labeler.yml remain untouched while labels defined there continue to synchronize, with the behavior covered by tests.
Written by the indexing model from the issue text.
Description
Description:
I think that even with sync-labels: true, a label which is not defined in labeler.yml at all should not be removed.
Justification:
Some labels might be applied by other means, such as non-labeler workflows marking a PR as 'deployed' for example, which have no file or branch based (or any static/declarative) way of describing when they should exist.
If a label is not even defined according to paths etc., then it should not be removed by labeler - we should assume it has some other source.
If people want labeler to be an absolute source of truth for allowed labels, then an ignore key or similar would do - i.e. to define a list of allowed labels which aren't synchronised.
Are you willing to submit a PR?
Willing but not that familiar.
- Dominant language
- TypeScript
- Stars
- 2.5k
- Forks
- 488
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from actions/labeler
-
feature request
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
When a workflow is triggered via workflow_dispatch, it cannot match the corresponding branch.Possibly taken @v-chiranjib-swain claimed this 2 days ago. Openbug
Difficulty 3/5 1-2 days Newbie friendliness 52/100
-
Feature request: top-level `ignore` list for files that should never trigger labelsPossibly taken @janhoy claimed this 104 days ago. Openfeature request
Difficulty 3/5 1-2 days Newbie friendliness 55/100
-
feature request
Difficulty 3/5 1-2 days Newbie friendliness 58/100
-
feature request
Difficulty 3/5 1-2 days Newbie friendliness 48/100
Similar issues
-
Difficulty 1/5 1-3 hours Newbie friendliness 87/100
Maintainers usually reply within 1 day
-
🛠️ dette technique
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
betagouv/mon-entreprise#4752 · 1 comment ·
Maintainers usually reply within 5 days
-
type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
franciscoBSalgueiro/en-croissant#1111 ·
Maintainers usually reply within 2 days
-
area/providers type/feature version/v2
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
anomalyco/opencode#64845 · 1 comment ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day