Follow CODEOWNERS file
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 32/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- github-actions, typescript
Research direction
No source file or test is named. Start by reviewing the labeler configuration and how CODEOWNERS ownership is represented for pull requests, then compare that with the proposed codeowner and codeowners entries. Done means a documented, tested mapping can apply labels when the corresponding owner is pinged without breaking existing glob and negation rules.
Written by the indexing model from the issue text.
Description
Description:
Add the option to use the CODEOWNERS (+ a file that map some codeowners to labels) to the labeler
For instance:
# Add 'repo' label to any root file changes
repo:
- '*'
# Add '@domain/core' label to any change within the 'core' package
'@domain/core':
- package/core/*
- package/core/**/*
# Add 'test' label to any change to *.spec.js files within the source dir
test:
- src/**/*.spec.js
# Add 'source' label to any change to src files within the source dir EXCEPT for the docs sub-folder
source:
- any: ['src/**/*', '!src/docs/*']
# Add 'frontend` label to any change to *.js files as long as the `main.js` hasn't changed
frontend:
- any: ['src/**/*.js']
all: ['!src/main.js']
# HERE IS THE ADDITION
# Add 'label-from-codeowner' label that gets added when the owner '@name-of-the-owner' gets pinged on a PR
label-from-codeowner:
- codeowner: @name-of-the-owner
# or could be follow multiple owners
codeowners: ['@name-of-the-owner']
Justification:
In project with teams, codeowners is a great feature to get pinged, but it cannot really help to view afterwards which teams were pinged by a PR (as the team gets replaced by the person that reviewed the PR).
To fix this, I use labels with a similar subset of the CODEOWNERS config.
But sometimes it can be a bit tricky to find the perfect equivalent for the CODEOWNERS syntax using glob pattern.
Are you willing to submit a PR?
Yes, if this PR is approved, I can work on a PR for that
- Dominant language
- TypeScript
- Stars
- 2.5k
- Forks
- 488
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from actions/labeler
-
feature request
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
When a workflow is triggered via workflow_dispatch, it cannot match the corresponding branch.Possibly taken @v-chiranjib-swain claimed this 2 days ago. Openbug
Difficulty 3/5 1-2 days Newbie friendliness 52/100
-
Feature request: top-level `ignore` list for files that should never trigger labelsPossibly taken @janhoy claimed this 104 days ago. Openfeature request
Difficulty 3/5 1-2 days Newbie friendliness 55/100
-
feature request
Difficulty 3/5 1-2 days Newbie friendliness 58/100
-
feature request
Difficulty 3/5 1-2 days Newbie friendliness 48/100
Similar issues
-
type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
db-ux-design-system/core-web#8856 ·
Maintainers usually reply within 1 day
-
'!' breaking change is lost when the commit also has an empty BREAKING CHANGE footerPossibly taken @wittdennis claimed this today. Openpriority: p3 type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
googleapis/release-please#2971 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 87/100
Maintainers usually reply within 1 day
-
🛠️ dette technique
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
betagouv/mon-entreprise#4752 · 1 comment ·
Maintainers usually reply within 5 days