More clarity on id-token: write
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Documentation
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- github-actions
- Domain
- documentation, security
Research direction
Start with the README comment at the linked line around line 32 and review the existing GitHub documentation referenced by the issue. Clarify what id-token: write permits and its security impact in the README, with wording that addresses whether it grants broader write or account-level privileges.
Written by the indexing model from the issue text.
Description
The README includes this comment: https://github.com/actions/deploy-pages/blob/d6db90164ac5ed86f2b6aed7e0febac5b3c0c03e/README.md?plain=1#L32
Could we get more information on this?
It looks pretty scary. id-token: write implies that there is some deep and mysterious extra permission being granted to this workflow, potentially involving the ability to make writes and involving a token which might have permission to do other privileged things, maybe even at the account or organization level.
It's really hard to figure out the security impact of this configuration from existing GitHub documentation.
- Dominant language
- JavaScript
- Stars
- 967
- Forks
- 147
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from actions/deploy-pages
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
actions/deploy-pages#454 · 1 comment ·
-
Intermittent "No artifacts named github-pages" when deploy-pages runs right after upload-pages-artifact in the same jobPossibly taken @neilime claimed this 7 days ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 52/100
actions/deploy-pages#451 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
actions/deploy-pages#435 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
actions/deploy-pages#434 · 3 comments · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
actions/deploy-pages#418 · 19 comments · 12 reactions ·
All issues in actions/deploy-pages
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
check:passed logos:edit
Difficulty 1/5 Under an hour Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
db-d1-sqlite: upsert is aliased to updateOne, so payload.kv.set never inserts new keysPossibly taken @pcbeingused333 claimed this today. OpenBug db: d1-sqlite Payload OSS
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
payloadcms/payload#19766 ·
Maintainers usually reply within 1 day
-
Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
inverse-inc/packetfence#9707 ·
Maintainers usually reply within 1 day
-
feedback simulation workshop
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
githubnext/gh-aw-workshop#5896 ·
Maintainers usually reply within 1 day