Add rough error handler for Octokit response parsing failures to `1.x` and `2.x` release
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript, node.js
Research direction
Start by reviewing #258 and the linked request.js PR 648, then locate the response-parsing path used by the 1.x and 2.x releases. Confirm how Node 16 compatibility constrains the workaround; done means non-JSON or empty error responses no longer produce misleading parsing errors in Actions logs.
Written by the indexing model from the issue text.
Description
This is intended as the 1.x and 2.x equivalent to shipping:
- #258
Addressing #258 will resolve misleading error scenarios where the error message that shows up in the Actions logs says something like HttpError: invalid json response body and reason: Unexpected end of JSON input. This occurs when Octokit receives a response with an error code (e.g. 400) but the accompanying response text is either not JSON-compatible for parsing, or is just not provided at all (empty).
This was resolved in Octokit with the following PR:
However, the subsequent Octokit release is not compatible with Node 16.x, and therefore cannot be pulled in as a dependency until we merge #256 and cut a new 3.x release.
Sadly, a new 3.x release won't help all of our GHES customers.
Therefore, we should consider implementing a rough workaround fix (i.e. a catch watching for this exact error) in this scenario so we log fewer "red herring" error messages. 🐟
- Dominant language
- JavaScript
- Stars
- 967
- Forks
- 147
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from actions/deploy-pages
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
actions/deploy-pages#454 · 1 comment ·
-
Intermittent "No artifacts named github-pages" when deploy-pages runs right after upload-pages-artifact in the same jobPossibly taken @neilime claimed this 7 days ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 52/100
actions/deploy-pages#451 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
actions/deploy-pages#435 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
actions/deploy-pages#434 · 3 comments · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
actions/deploy-pages#418 · 19 comments · 12 reactions ·
All issues in actions/deploy-pages
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
check:passed logos:edit
Difficulty 1/5 Under an hour Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
db-d1-sqlite: upsert is aliased to updateOne, so payload.kv.set never inserts new keysPossibly taken @pcbeingused333 claimed this today. OpenBug db: d1-sqlite Payload OSS
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
payloadcms/payload#19766 ·
Maintainers usually reply within 1 day
-
Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
inverse-inc/packetfence#9707 ·
Maintainers usually reply within 1 day
-
feedback simulation workshop
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
githubnext/gh-aw-workshop#5896 ·
Maintainers usually reply within 1 day