`error_count` input name is confusing

Open
#250 7 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
github-actions, javascript
Domain
ci-cd, devops

Research direction

The issue points to the actions/deploy-pages@v2 workflow input and the deployment-status polling shown in the log; start by tracing how error_count is interpreted during syncing_files. Done means the input name accurately describes its behavior and users can configure the desired error tolerance without misreading the setting.

Written by the indexing model from the issue text.

Description

    steps:
      - name: "Deploy to GitHub Pages"
        id: deployment
        uses: actions/deploy-pages@v2
        with:
          error_count: 0

I might've mis-interpreted the error_count when initially configuring the action. I want to allow no errors, however based on the below log this error_count seems to mean deployment_in_progress_poll_count or something like it.

Created deployment for b6872282209cb2c94d458dcc594dfddd82d733b9, ID: b6872282209cb2c94d458dcc594dfddd82d733b9
Getting Pages deployment status...
Current status: syncing_files
Error: Too many errors, aborting!
Error: Failed with status code: 0
Canceling Pages deployment...
Canceled deployment with ID b6872282209cb2c94d458dcc594dfddd82d733b9
Dominant language
JavaScript
Stars
967
Forks
147
PR merge metrics
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from actions/deploy-pages

All issues in actions/deploy-pages

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.