Overly restrictive tar-file requirements (leading `./` needed)
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 38/100
Research direction
No source file or test is named. First reproduce the behavior with the two tar commands on GNU tar 1.34 and inspect how deploy-pages validates archive paths. Done means archives containing entries such as index.html are accepted like ./index.html archives, or the required format is documented clearly.
Written by the indexing model from the issue text.
Description
Hey,
I'm investigating a very specific issue using deploy-pages, and I think I've narrowed it down to a 100% repro. I'm using a custom build setup with a static page generator. Due to some build process changes I ended up moving from packaging loose files to directly building the tar archive (i.e., replacing upload-pages-artifact). That change broke this action. After a lot of testing; I've found that the two commands below end up bisecting the behavior. In practice, the latter archive is generated by a build tool without using the tar command.
This works:
tar cvf "artifact.tar" ./*
While this fails:
tar cvf "artifact.tar" *
In a hypothetical situation where we're only tarring an index.html the first command creates the tar file [./index.html], whereas the latter is simply [index.html]. Not handling this seems like a bug, but at a minimum it should probably be documented on this action if it's intentionally required. As far as I can tell, on my specific version of tar, these two archives extract identically regardless of cwd, -C, etc.
This is the error message when using the latter format:
Artifact could not be deployed. Please ensure the content does not contain any hard links, symlinks and total size is less than 10GB.
The same behavior can also be observed by adding --xform s:'./':: to the working command, which indicates that this is indeed a result of the directory structure inside the tar.
The tar used for testing:
tar (GNU tar) 1.34
Happy to supply any more info as necessary.
- Dominant language
- JavaScript
- Stars
- 967
- Forks
- 147
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from actions/deploy-pages
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
actions/deploy-pages#454 · 1 comment ·
-
Intermittent "No artifacts named github-pages" when deploy-pages runs right after upload-pages-artifact in the same jobPossibly taken @neilime claimed this 7 days ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 52/100
actions/deploy-pages#451 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
actions/deploy-pages#435 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
actions/deploy-pages#434 · 3 comments · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
actions/deploy-pages#418 · 19 comments · 12 reactions ·
All issues in actions/deploy-pages
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
check:passed logos:edit
Difficulty 1/5 Under an hour Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
db-d1-sqlite: upsert is aliased to updateOne, so payload.kv.set never inserts new keysPossibly taken @pcbeingused333 claimed this today. OpenBug db: d1-sqlite Payload OSS
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
payloadcms/payload#19766 ·
Maintainers usually reply within 1 day
-
Type: Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
inverse-inc/packetfence#9707 ·
Maintainers usually reply within 1 day
-
feedback simulation workshop
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
githubnext/gh-aw-workshop#5896 ·
Maintainers usually reply within 1 day