Single-subject attestations in `actions/attest@v2`
Maintainers usually reply within 1 day
@AA-Turner is already working on this.
Since Feb 28, 2025.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- github-actions, python, typescript
Research direction
Start by reviewing the v2 behavior described in #164, then compare it with the referenced Sphinx workflow and utils/convert_attestations.py. Check the pypi-attestations requirement for exactly one subject and determine whether the action can expose one-attestation-per-artifact behavior and artifact filenames in its outputs; done means the supported behavior and output contract are documented and covered by the action's tests.
Written by the indexing model from the issue text.
Description
Hi,
Thank you for maintaining this action!
We currently use version 1 of the action, which (as I understand it) creates one attestation per artefact, writing each to a new line of a JSONL document. #164 changed this to creating a single attesation with multiple 'subjects'.
We're using the action for integration with GitHub, and then converting the Sigstore attestations to the format expected by the Python Package Index (PEP 740). When upgrading the action to version 2, I get a failure with pypi-attestations, which requires that there must be exactly one subject in the statement.
My questions are therefore:
- Is it possible to replicate the v1 behaviour of one-attestation-per-artefact with v2 of the action?
- Ought this be fixed in
pypi-attestationsinstead? (I will open a similar issue there and cross-link it) - (low priority; usability) Is it possible to include the filename of the attested artefacts somehow in the action outputs? I currently extract this via JSON decoding a base64-encoded blob inside the Sigstore JSON, which isn't the most ergonomic.
For my use-case, I can just use two invocations of the article, as our build process only produces two artefacts, but this does not scale well should we create more outputs in the future.
Thanks,
Adam
References:
- https://github.com/sphinx-doc/sphinx/blob/master/.github/workflows/create-release.yml
- #164
- https://github.com/sphinx-doc/sphinx/blob/master/utils/convert_attestations.py
- https://peps.python.org/pep-0740/
- https://github.com/trailofbits/pypi-attestations
- https://github.com/trailofbits/pypi-attestations/blob/v0.0.21/src/pypi_attestations/_impl.py#L274-L275
- Dominant language
- TypeScript
- Stars
- 187
- Forks
- 65
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 8
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from actions/attest
-
Difficulty 1/5 1-3 hours Newbie friendliness 87/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
solidjs/solid-docs#1716 ·
Maintainers usually reply within 1 day
-
bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Progress indicated by console logs is off by onePossibly taken @marceliwac claimed this today. Openbug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
aws-samples/aws-cdk-examples#1336 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
melgarafael/DeskcommCRM#4999 · 1 comment ·
Maintainers usually reply within 1 day
-
type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days