Mislabeling of eTLD-`n`

Open
#23 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
networking

Research direction

Read the linked publicsuffix.org wildcard discussion and issue #21, then reproduce the publicsuffix2 behavior using the example PSL entries. Locate the wildcard and eTLD matching entry point and existing tests; done means the reported eTLD-n mislabeling is corrected and covered by a regression test.

Written by the indexing model from the issue text.

Description

As mentioned in https://github.com/publicsuffix/list/pull/1872#issuecomment-1863614188

Multiple psl libraries share the same bug while handling wildcards.

I went over all the FOSS implementations in https://publicsuffix.org/learn/ , and I found 3 of them behave funny for wildcard domains. In particular:

Seems to all mislabel eTLD-n x [eTLD minus n] (with n from 0 to infinite), as an eTLD, if another eTLD y is defined as a subdomain of that x eTLD-n.

As an example publicsuffix2 behaviour with the following patch:

 // Linode : https://linode.com
 // Submitted by <[email protected]>
 members.linode.com
-nodebalancer.linode.com
+*.nodebalancer.linode.com
+*.linodeobjects.com
+ip.linodeusercontent.com

Example here:

291734330-d38c352b-b420-45fb-93dc-438ebbea2f02

This bug has already been reported in this library here

Dominant language
Python
Stars
31
Forks
16
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aboutcode-org/python-publicsuffix2

All issues in aboutcode-org/python-publicsuffix2

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.