line_number property typed to Optional[str]

Open
#8 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start at src/pip_requirements_parser.py around line 420 and inspect how the line_number property is typed. Then inspect the distribution packaging configuration to determine where the py.typed marker belongs. Done means the annotation no longer incorrectly uses Optional[str] and the distribution includes py.typed so mypy recognizes the package as typed.

Written by the indexing model from the issue text.

Description

https://github.com/nexB/pip-requirements-parser/blob/0da228a3229dfb0074dad202e3dc7f9cf4103a23/src/pip_requirements_parser.py#L420

Also please add a py.typed to your distribution. I believe it is all 100% typed and mypy thinks otherwise since this is missing.

PR #9

Dominant language
Python
Stars
20
Forks
17
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aboutcode-org/pip-requirements-parser

All issues in aboutcode-org/pip-requirements-parser

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.