Overly permissive egg fragment parsing in URL requirements

Open
#7 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start by reviewing the parser behavior described in this issue and the linked pip issue #11567, since the accepted syntax is awaiting pip's resolution. Done means the library's handling of #egg=packagename==packageversion matches the decision made there, with coverage added for the invalid fragment.

Written by the indexing model from the issue text.

Description

First of all, thanks for maintaining this parser! It's been invaluable within pip-audit.

Per https://github.com/pypa/pip/issues/11567: #egg=packagename==packageversion isn't actually valid, but this parser (and some others) accept it.

I'll wait for a resolution on that pip issue first, but I'm happy to submit a PR here that brings this library into compatibility with whatever pip decides 🙂

Dominant language
Python
Stars
20
Forks
17
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aboutcode-org/pip-requirements-parser

All issues in aboutcode-org/pip-requirements-parser

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.