Some failing tests on windows

Open
#1 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
testing

Research direction

Start with the listed failing tests in pip_requirements_parser_tests/test_requirements_file.py and pip_requirements_parser_tests/unit/test_req.py, ideally on Windows or a Windows CI environment. Compare the failures against the linked conda-forge build log and the requirements data files named in the test parameters. Done means the Windows-specific test assumptions are identified and the affected tests pass or are adjusted appropriately.

Written by the indexing model from the issue text.

Description

Thanks for pip-requirements-parser!

I'm looking to package this for conda-forge, and while, as a noarch package, we'd eventually only be building releases on linux, the initial review is built on the Big Three operating systems. Not-entirely-surprisingly, there are some gotchas on windows:

FAILED pip_requirements_parser_tests/test_requirements_file.py::test_RequirementsFile_to_dict[C:\\bld\\pip-requirements-parser_1646957052592\\test_tmp\\tests\\pip_requirements_parser_tests\\data\\requirements\\packaging-docs-examples.txt]
FAILED pip_requirements_parser_tests/test_requirements_file.py::test_RequirementsFile_to_dict[C:\\bld\\pip-requirements-parser_1646957052592\\test_tmp\\tests\\pip_requirements_parser_tests\\data\\requirements\\pip-docs-examples-vcs.txt]
FAILED pip_requirements_parser_tests/test_requirements_file.py::test_RequirementsFile_to_dict[C:\\bld\\pip-requirements-parser_1646957052592\\test_tmp\\tests\\pip_requirements_parser_tests\\data\\requirements\\pip-docs-examples.txt]
FAILED pip_requirements_parser_tests/test_requirements_file.py::test_RequirementsFile_dumps_unparse[C:\\bld\\pip-requirements-parser_1646957052592\\test_tmp\\tests\\pip_requirements_parser_tests\\data\\requirements\\pip-docs-examples-vcs.txt]
FAILED pip_requirements_parser_tests/test_requirements_file.py::test_RequirementsFile_dumps_unparse[C:\\bld\\pip-requirements-parser_1646957052592\\test_tmp\\tests\\pip_requirements_parser_tests\\data\\requirements\\pip-docs-examples.txt]
FAILED pip_requirements_parser_tests/unit/test_req.py::TestInstallRequirement::test_unexisting_path

I intend to skip them and move on, as they look like some test assumptions (maybe not even from this codebase), but figured it was worth documenting here.

Thanks again!

Dominant language
Python
Stars
20
Forks
17
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aboutcode-org/pip-requirements-parser

All issues in aboutcode-org/pip-requirements-parser

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.