Fix meetable not able to read database-backend settings in docker compose
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- Half a day
- Newbie friendliness
- 72/100
Research direction
Start at Setting::value() in app/Setting.php, where the check for /var/www/html/.env short-circuits any value already injected as an environment variable. Read how the compose file passes env_file into the app and worker services, then pick one of the two paths the issue offers: fall back to getenv()/$_ENV in that check, or add the read-only .env volume to both services in the compose file. Done means a setting supplied only through compose environment variables shows up in the app, verified by bringing the stack up and loading a page that reads a database-backed setting.
Written by the indexing model from the issue text.
Description
With the current setup meetable isn't able to read database-backed settings because it requires /var/www/html/.env (see https://github.com/aaronpk/Meetable/blob/7d2d22ab7f85f7fef07a02ee99b9216df84c5ec4/app/Setting.php#L15). That's a problem. Settings configured just weren't applied. The solution is either to modify that check in the Setting::value() to also consider loaded env variables or load the env to the location where meetable expects them by adding the following to both the app and worker:
volumes:
- ./.env:/var/www/html/.env:ro
That's kinda annoying though bc the compose is already injecting the .env as env variables.
- Dominant language
- PHP
- Stars
- 171
- Forks
- 14
- Avg merge
- 1m
- Merged PRs (30d)
- 1
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aaronpk/Meetable
-
Difficulty 2/5 1-3 hours Newbie friendliness 40/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 52/100
-
Difficulty 3/5 1-2 days Newbie friendliness 30/100
-
Difficulty 3/5 Half a day Newbie friendliness 12/100
All issues in aaronpk/Meetable
Similar issues
-
bug-report bug-report-triage customer report
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Codeinwp/tweet-old-post#1177 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 60/100
sonata-project/dev-kit#3119 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
🧠 Admin
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
RSA PKCS#1 v1.5 verify fails for SHA-512/224, SHA-512/256 and SHA-3 (UnhandledMatchError on 4.x)Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day