fix: handle blank push notification config id consistently across transports
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
Research direction
Examine the GetTaskPushNotificationConfigParams class and its constructor validation. Look at the GrpcTransport and RestTransport implementations to see how they handle the id parameter. Write tests for the blank-id case to ensure consistent behavior. The fix should make both transports treat a blank id the same way, either as absent or as an empty string, and update the Javadoc accordingly.
Written by the indexing model from the issue text.
Description
GetTaskPushNotificationConfigParams rejects a null id but permits an
empty string, and the two transports diverge on that input:
GrpcTransportsends.setId("").RestTransporttreats it as absent and requests the trailing-slash
"default config" URL.
Identical caller code against the same ClientTransport method therefore
produces two different requests. This aligns both on
and adds coverage for the blank-id path, which was previously untested.
Also corrects the Javadoc on GetTaskPushNotificationConfigParams, which
described id as optional and documented @throws for taskId or tenant
when the constructor actually validates taskId and id.
- Dominant language
- Java
- Stars
- 500
- Forks
- 179
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 40
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from a2aproject/a2a-java
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
a2aproject/a2a-java#1197 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
a2aproject/a2a-java#1196 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
a2aproject/a2a-java#464 · 1 comment ·
Maintainers usually reply within 1 day
-
Create a sample that demonstrates how to use a shared contextId across multiple tasksMay be free again @tanish111 claimed this 346 days ago, and no pull request is open. Opensample
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
a2aproject/a2a-java#375 · 5 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
[Bug]: REST transport never signals normal stream completion to the client (SSE hangs until timeout)Open
Difficulty 4/5 3-5 days Newbie friendliness 48/100
a2aproject/a2a-java#1194 ·
Maintainers usually reply within 1 day
All issues in a2aproject/a2a-java
Similar issues
-
cbor
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
FasterXML/jackson-dataformats-binary#844 ·
Maintainers usually reply within 1 day
-
improvement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
apache/iceberg#18351 · 1 comment ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
repowise-dev/repowise#2945 · 1 comment ·
Maintainers usually reply within 1 day
-
Interpolating settings.xml can lead to malformed XML when variable value contains double-hyphenOpenbug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
apache/maven#13321 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
liquid-java/liquidjava#321 ·
Maintainers usually reply within 2 days