Dialogs render with the light theme on dark pages
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- react, typescript
Research direction
Start with src/components/ui/dialog.tsx and inspect which theme tokens its dialog surface and form controls use, then compare them with the page theme on /directory. Check both the offer details dialog and eligibility sheet in light and dark mode; done when dialogs match the active theme and text, inputs, selects, and checkboxes remain readable.
Written by the indexing model from the issue text.
Description
Route
/directory (and any page that opens a dialog from src/components/ui/dialog.tsx).
Steps to reproduce
- Open
/directorywith the dark theme (the directory's default look). - Click an offer's description to open its details dialog, or click "Set my eligibility" to open the eligibility sheet.
Actual behavior
The dialog renders as a light panel on the dark page. It uses the shadcn popover tokens instead of the page theme, so it looks out of place and the contrast of its inputs and text changes.
Expected behavior
Dialogs follow the active theme in both light and dark mode, with readable text, inputs, selects, and checkboxes.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 6
- Avg merge
- 21h 33m
- Merged PRs (30d)
- 48
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Your-Voldemort/StudentStack
-
CI passes NEXT_PUBLIC_SUPABASE_ANON_KEY but the app reads NEXT_PUBLIC_SUPABASE_PUBLISHABLE_KEY; e2e job installs only ChromiumPossibly taken @rootsiemen claimed this 1 day ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Your-Voldemort/StudentStack#126 · 1 comment ·
Maintainers usually reply within 1 day
-
Flag curated flagship opportunities whose dates need a refreshPossibly taken @rootsiemen claimed this 1 day ago. Open
Difficulty 5/5 Over a week Newbie friendliness 35/100
Your-Voldemort/StudentStack#120 · 2 comments ·
Maintainers usually reply within 1 day
-
Reviews: add "Most helpful" sort with helpful votesPossibly taken @Aryan-Techie claimed this today. Open
Difficulty 5/5 Over a week Newbie friendliness 35/100
Your-Voldemort/StudentStack#119 · 2 comments ·
Maintainers usually reply within 1 day
All issues in Your-Voldemort/StudentStack
Similar issues
-
[Bug]: REST API URL starting with "http" but no scheme (e.g. httpbin.org/get) is not given an http:// prefixPossibly taken @ItsDeadlyProgrammer claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
appsmithorg/appsmith#42471 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ehmpathy/rhachet-roles-bhrain#705 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Status: Triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
mermaid-js/mermaid#8546 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
braintrustdata/braintrust-sdk-javascript#2659 ·
Maintainers usually reply within 1 day