UIP-3014 Warn when key uses default toString impl
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Locate the key-handling entry point and the existing console-warning path, then reproduce the two Foo examples from the issue. The work is done when values using Dart's default object toString form trigger a console warning while other key values continue to work.
Written by the indexing model from the issue text.
Description
With key being dynamic and toString-ing values, it's easy to pass in any object.
It's also easy to pass in objects with non-unique toString implementations, such as the default Object.toString, and not notice that the value won't help when keying.
class Foo {
final bar;
Foo(this.bar);
}
..key = new Foo(1) // Uses "Instance of 'Foo'" as key
..key = new Foo(2) // Uses "Instance of 'Foo'" as key
We should check whether values like this are specified (perhaps via a regex, like ^Instance of '[_\$a-zA-Z0-9]+'$) and warn in the console.
- Dominant language
- Dart
- Stars
- 432
- Forks
- 57
- Avg merge
- 12m
- Merged PRs (30d)
- 2
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Workiva/over_react
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Workiva/over_react#981 · 4 comments · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
Workiva/over_react#947 · 8 comments · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Workiva/over_react#942 · 8 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
Workiva/over_react#939 · 1 comment ·
-
Difficulty 3/5 1-2 days Newbie friendliness 20/100
Workiva/over_react#644 · 3 comments ·
All issues in Workiva/over_react
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
linagora/twake-on-matrix#3435 ·
Maintainers usually reply within 3 days
-
右下角的图标问题Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
[Domain Activation] Show a user-friendly error when sending is blocked pending domain activationOpen
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
linagora/tmail-flutter#4953 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
genkit-ai/genkit-dart#587 ·
Maintainers usually reply within 1 day