Discussion: handling of PHP version / os dependent results
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
Research direction
Start by reading the RunWordPressInstallerStepRunner entry point and compare its reported output across the PHP versions described in the issue. The discussion does not identify files, tests, or a settled design; work is complete only once the project has agreed on whether and how version- and OS-dependent responses should be unified.
Written by the indexing model from the issue text.
Description
I've noticed that the RunWordPressInstallerStepRunner returns different success messages for different PHP versions.
For PHP <= 7.3 it returns:
#!/usr/bin/env php\n
Success: WordPress installed successfully.
And for PHP > 7.3 it returns:
Success: WordPress installed successfully.
That's just a small / funny wp-cli quirk and it is quite easy to handle, yet it begs a crucial question - should we take the responsibility of delivering unified responses for all PHP / os versions?
Keeping huge ambitions for playground and blueprints in mind, not taking the burden at code level will inevitably push it to support / end users. Although it may look like a nitpick today, it won't take long until this will start causing real-life problems. So, I'd recommend we include a design principle to... care about this... I guess.
- Dominant language
- PHP
- Stars
- 61
- Forks
- 22
- Avg merge
- 19h 34m
- Merged PRs (30d)
- 7
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from WordPress/php-toolkit
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
WordPress/php-toolkit#313 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 58/100
WordPress/php-toolkit#306 ·
-
WPCS complianceOpen
Difficulty 4/5 3-5 days Newbie friendliness 35/100
WordPress/php-toolkit#157 · 1 reaction ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
WordPress/php-toolkit#138 · 7 comments · 2 reactions ·
-
[Blueprints v2] Constraint the Blueprint bundle formatMay be free again @JanJakes claimed this 431 days ago, and no pull request is open. OpenBlueprints enhancement
WordPress/php-toolkit#132 · 4 comments · 1 assignee ·
All issues in WordPress/php-toolkit
Similar issues
-
sync-en
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Maintainers usually reply within 1 day
-
sync-en
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 3 days
-
Перевод устарел
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
-
Form
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
symfony/symfony-docs#23159 ·
Maintainers usually reply within 3 days
-
bug component: bulk editor support
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Yoast/wordpress-seo#23669 ·
Maintainers usually reply within 3 days