Aquarium normal maps load in a different way depending on browser (artifacts on MS Edge)

Open
#24 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript

Research direction

Start by reproducing the aquarium sample in MS Edge and another browser, then trace how the normal map PNG files are loaded and decoded. Compare the resulting normal-map rendering and investigate the reported UNPACK_COLORSPACE_CONVERSION_WEBGL limitation or JavaScript decoding alternative; done means the artifacts are gone in Edge without regressing other browsers.

Written by the indexing model from the issue text.

Description

It seems as if color space handling of loaded images differs between MS Edge and other browsers. This causes normal maps to be distorted on MS Edge. The fix for this according to the spec would be setting UNPACK_COLORSPACE_CONVERSION_WEBGL to NONE, but unfortunately MS Edge doesn't implement that at the moment. Another possible fix would be to decode the normal map PNG files in JS.

Dominant language
Wolfram Language
Stars
982
Forks
292
Avg merge
1d 6h
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from WebGLSamples/WebGLSamples.github.io

All issues in WebGLSamples/WebGLSamples.github.io

Similar issues

More Computer Graphics issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.