Are indices in the name section expected to be valid up front?

Open
#12 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
wasm
Domain
compilers

Research direction

Start with the name-section tests referenced from #11 and review how SpiderMonkey parses name sections, especially before a function body is fully parsed. Compare the current tests with the specification's wording, then establish whether out-of-bounds indices are accepted and update the tests to reflect the decided rule.

Written by the indexing model from the issue text.

Description

In #11 I added tests for the name section that assert things like "invalid type index 123" or "invalid label index 123 for function 1". This seemed reasonable until I went to implement it in SpiderMonkey and remembered that we have no idea how many labels a function has without parsing the full body of the function, which we do quite lazily and in parallel, which is very inconvenient for name section validation.

In principle, we don't actually need to validate all the indices in the name section. If extra names are present that don't correspond to any actual items in the module, that doesn't really hurt anyone (except perhaps the user downloading the oversize module, but they had to anyway because it's a custom section). The spec doesn't actually say today whether the indices in the name section are expected to be valid, only that the name subsections themselves are well-formed.

Basically my question is: should we just delete these valid-index tests across the board / flip them to asserting validity, or should we keep them? My preference would be to flip them all to asserting that out-of-bounds indexes are actually valid.

Dominant language
WebAssembly
Stars
12
Forks
2
PR merge metrics
No merged PRs in 30d

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from WebAssembly/extended-name-section

All issues in WebAssembly/extended-name-section

Similar issues

More Compilers issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.