descriptor / described type ordering constraints
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 15/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- wasm
- Domain
- compilers
Research direction
The payload names no files or tests. Start with the linked discussion in pull request 124 and the current rule that a described type must precede its descriptor. This is an open design question about whether to keep that ordering and whether descriptor types should come first, so a newcomer's first step is to read the thread and not to write code. Done means the maintainers agree on the ordering rule and the validation consequences are written down.
Written by the indexing model from the issue text.
Description
Currently we require a described type to appear before its descriptor type. The ordering constraint statically rules out descriptor cycles. The rationale for this ordering is that we expect described types to be referenced more frequently in the module, so it is better to give them smaller indices for smaller LEB index encoding. Also, it Just Makes Sense that you would want to see the "more concrete" type first.
However, @rossberg raised the questions of whether we need the ordering constraint at all, and if so, whether it would be nicer to have descriptor types first, matching the necessary order of construction.
There should be no runtime problem with allowing descriptor cycles; the involved types will just be uninhabitable. There might be some small extra complication in streaming type decoding and validation, since the validator would no longer be able to assume that described and descriptor types will or will not have been decoded.
- Dominant language
- WebAssembly
- Stars
- 13
- Forks
- 3
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 17
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from WebAssembly/custom-descriptors
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
WebAssembly/custom-descriptors#132 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
WebAssembly/custom-descriptors#107 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
WebAssembly/custom-descriptors#100 ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
WebAssembly/custom-descriptors#98 · 2 reactions ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
WebAssembly/custom-descriptors#95 · 1 comment ·
Maintainers usually reply within 1 day
All issues in WebAssembly/custom-descriptors
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
Maintainers usually reply within 1 day
-
DAE2 crashes on call.without.effects with a non ref.func expressionPossibly taken @stevenfontanella claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
WebAssembly/binaryen#9404 ·
Maintainers usually reply within 1 day
-
area:compiler effort:S impact:med platform:windows type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
area:Analysis enhancement
Difficulty 1/5 1-3 hours Newbie friendliness 69/100
facebookresearch/atlas-lean#5118 ·
Maintainers usually reply within 1 day
-
C-bugfix
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Quantinuum/hugr#3354 ·
Maintainers usually reply within 1 day