`pass` test failures on 32-bit systems
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cmake, python, wasm
- Domain
- compilers, testing-qa
Research direction
Reproduce the failure with the provided CMake, Ninja, and check.py commands, then inspect passes/O_fast-math.wast and passes/optimize-instructions-mvp.wast, focusing on their NaN CHECK lines. Done means both pass tests produce the expected NaN values on a 32-bit build.
Written by the indexing model from the issue text.
Description
When running
cmake -G Ninja -DCMAKE_CXX_FLAGS="-m32" -DCMAKE_C_FLAGS="-m32" -DCMAKE_BUILD_TYPE=Debug .
ninja
python3 check.py lit
I get test failures in passes/O_fast-math.wast and passes/optimize-instructions-mvp.wast. Both tests give the wrong NaN:
$ "filecheck" "/usr/local/google/home/stevenfont/code/binaryen/test/lit/passes/O_fast-math.wast"
# command output:
/usr/local/google/home/stevenfont/code/binaryen/test/lit/passes/O_fast-math.wast:41:17: error: CHECK-NEXT: expected string not found in input
;; CHECK-NEXT: (f32.const -nan:0x23017a)
^
<stdin>:19:1: note: scanning from here
(f32.const -nan:0x63017a)
^
error: command failed with exit status: 1
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 70
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from WebAssembly/binaryen
-
Difficulty 2/5 Half a day Newbie friendliness 76/100
WebAssembly/binaryen#9018 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
WebAssembly/binaryen#9123 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
WebAssembly/binaryen#9122 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
WebAssembly/binaryen#9086 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
WebAssembly/binaryen#9038 · 5 comments ·
All issues in WebAssembly/binaryen
Similar issues
-
todo:perf
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
objectionary/eo#8894 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
objectionary/phie#154 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
objectionary/jeo-maven-plugin#1774 ·
-
Minor breakage w/ LLVM 7: `test_llvm.cpp: error: cannot convert 'llvm::Module' to 'llvm::Module*'` Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100