Most lit/help tests fail with new python-filecheck
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- Half a day
- Newbie friendliness
- 76/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- wasm
- Domain
- compilers, testing-qa
Research direction
Start in test/lit/help, where the wasm* help-output tests use FileCheck directives. Run the wasm-shell example with filecheck 1.0.3, then inspect the other lit/help tests for empty CHECK-NEXT directives. Done means the affected help tests pass with the new upstream FileCheck behavior.
Written by the indexing model from the issue text.
Description
In binaryen lit tests, filecheck is used to test the --help output of various wasm* tools.
With filecheck-0.0.24, the following test passes:
$ wasm-shell --help | filecheck help/wasm-shell.test
$
However, with filecheck-1.0.3 from the new upstream repo, it fails:
$ wasm-shell --help | filecheck help/wasm-shell.test
help/wasm-shell.test:4:9 found empty check string with prefix 'NEXT:'
;; CHECK-NEXT:
^
$
New upstream says the new behaviour is closer to the original filecheck and recommends using CHECK-EMPTY instead of CHECK-NEXT.
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 77
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from WebAssembly/binaryen
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
WebAssembly/binaryen#9135 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
WebAssembly/binaryen#9133 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 52/100
WebAssembly/binaryen#9123 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
WebAssembly/binaryen#9122 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
WebAssembly/binaryen#9086 · 2 comments ·
All issues in WebAssembly/binaryen
Similar issues
-
flang:fir-hlfir
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
llvm/llvm-project#225935 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
objectionary/eo#8923 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Coarray integration tests carry no LABELS, so run_tests.py silently skips them under every backend Opencoarray
Difficulty 2/5 1-3 hours Newbie friendliness 70/100