Wasm-opt not deduplicating repeated struct.gets on unchanged local

Open
#8,312 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
wasm
Domain
compilers

Research direction

Start with wasm-opt and reproduce the repeated local.get/struct.get pattern from the issue. Trace the optimizer behavior for unchanged locals and determine where repeated struct.gets could be recognized. Done means the pattern is deduplicated while preserving the shown control flow, with code-size or performance impact checked.

Written by the indexing model from the issue text.

Description

Consider the larger wasm snippet below. There are multiple instances of the same group of instructions:

local.get $var0
struct.get $#Top $field0

$var0 doesn't change between these struct.gets. I would expect wasm-opt to be able to identify this, do the lookup once and store it in a local prior to entering the block. This would save both code size and performance. We have some functions with hundreds of these patterns so the code size savings from this could be significant.

...
block $label1
  block $label0 (result (ref $#Top))
    local.get $var0
    br_on_non_null $label0
    local.get $var0
    global.get $C6307 SymbolConstant(#[]=)
    local.get $var4
    call $_typeArgumentsToList
    local.get $var3
    call $_positionalParametersToList
    local.get $var10
    call $_namedParametersToMap
    call $_Invocation.method
    call $NoSuchMethodError._throwWithInvocation
    unreachable
  end $label0
  local.tee $var0
  struct.get $#Top $field0
  i32.const 15
  i32.eq
  br_if $label1
  local.get $var0
  struct.get $#Top $field0
  i32.const 16
  i32.eq
  if
    local.get $var0
    ref.as_non_null
    local.get $var4
    local.get $var3
    global.get $C5979 WasmArray<Object>[0]
    call $__ConstMap&_HashFieldBase&MapMixin&_HashBase&_OperatorEqualsAndHashCode&_LinkedHashMapMixin&_MapCreateIndexMixin&_UnmodifiableMapMixin.[]= invocation type checker
    drop
    return
  end
  local.get $var0
  struct.get $#Top $field0
  i32.const 17
  i32.eq
  br_if $label1
  local.get $var0
  struct.get $#Top $field0
  i32.const 18
  i32.eq
  if
    local.get $var0
    ref.as_non_null
    local.get $var4
    local.get $var3
    global.get $C5979 WasmArray<Object>[0]
    i32.const 0
    call_indirect (param (ref $#Top) (ref $Array<_Type>) (ref $Array<Object?>) (ref $Array<Object?>)) (result (ref null $#Top)) $&
    drop
    return
  end
  local.get $var0
  struct.get $#Top $field0
  i32.const 51
  i32.eq
  if
    local.get $var0
    ref.as_non_null
    local.get $var4
    local.get $var3
    global.get $C5979 WasmArray<Object>[0]
    call $CrossappCacheStorage.[]= invocation type checker
    drop
    return
  end
...
Dominant language
WebAssembly
Stars
8.6k
Forks
885
Avg merge
1d 20h
Merged PRs (30d)
64

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from WebAssembly/binaryen

All issues in WebAssembly/binaryen

Similar issues

More Compilers issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.