Type renaming behavior differs depending on view

Open
#8,491 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
50/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
cpp
Domain
reverse-engineering

Research direction

Reproduce the rename in linear/graph view and in the types view using the steps in the issue, then trace the two view-specific rename entry points. The change is done when renaming the same type from either view produces the same system-versus-user type classification.

Written by the indexing model from the issue text.

Description

Component: UI UI: Graph UI: Linear UI: Types

Version and Platform (required):

  • Binary Ninja Version: 6.1.10552-dev

Bug Description:
Renaming a type in linear/graph view keeps the type as a system type, but renaming from the types view changes it to a user type

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. Open any file
  2. Rename a type from linear view
  3. Notice it stays in system types
  4. Undo
  5. Rename the same type from types view
  6. Notice it gets moved to user types

Expected Behavior:
Renaming should have the same behavior regardless of where it happens

Screenshots/Video Recording:
Image

Dominant language
C++
Stars
1.3k
Forks
298
Avg merge
5d 5h
Merged PRs (30d)
19

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Vector35/binaryninja-api

All issues in Vector35/binaryninja-api

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.