ortho missing blast files did not throw error
@ryanrdoherty is already working on this.
Since Dec 20, 2023.
Assessment
This issue has not been assessed yet.
Description
a user complained but if we had had emailed an error we would have fixed it long ago (asume it has been an issue since we released nov 28).
ryan slacks in ui-infra:
Looks like the executable completes "successfully" (need to see if the process query checks return code), and then the text results are just what see.
I found where we set the return code. We could easily throw exception if != 0, but that might have undesirable effects. Need to look more if you want to do something else here.
We should try to define the behavior we want and then make sure it's doing what we want in WDK. Remember the issue where a plugin failed and then we cached 0 rows in the WDK cache as if it had succeeded with zero rows? I'm worried handling this non-zero return code as an exception might recause that issue.
- Dominant language
- Java
- Stars
- 1
- Forks
- 4
- Avg merge
- 1m
- Merged PRs (30d)
- 2
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from VEuPathDB/WDK
-
Difficulty 3/5 1-2 days Newbie friendliness 62/100
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Feature request: Add redirectUrl query parameter support to `/service/logout` endpointPossibly taken A pull request linked to this issue is open or already merged. Openenhancement
Difficulty 3/5 1-2 days Newbie friendliness 42/100
-
Refine login API to get rid of cookies and automatic guestsPossibly taken @ryanrdoherty claimed this 685 days ago. Open
Similar issues
-
BoxAttachmentMulti parsing leaks IOException / ArrayIndexOutOfBoundsException on malformed content instead of IllegalArgumentExceptionPossibly taken @Kshot3000 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
ergoplatform/ergo-appkit#272 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
utopia-rise/godot-jvm#1004 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
spring-projects/spring-grpc#442 ·