Add validation to IDs included in dataset params
A pull request for this has already been merged.
- #48 by @dmgaldi — merged
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
No file or test is named. Start by locating the Java validation entry point for dataset parameters, then inspect how uploaded IDs are checked. Done means IDs containing characters outside digits, letters, '.', '-', '_', ':', '(' and ')' are rejected before they reach downstream processing.
Written by the indexing model from the issue text.
Description
Overview
We've recently had invalid files uploaded as dataset parameters in our WDK sites. These have not been rejected in validation, causing issues downstream. We would like to add basic validation to ensure IDs are restricted to the following characters:
[0-9][a-zA-Z].-_:()
We could alternatively wire up a regex parameter in the WDK model, though this would be a more considerable effort.
- Dominant language
- Java
- Stars
- 1
- Forks
- 4
- Avg merge
- 1m
- Merged PRs (30d)
- 2
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from VEuPathDB/WDK
-
Difficulty 3/5 1-2 days Newbie friendliness 62/100
-
Difficulty 4/5 3-5 days Newbie friendliness 38/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Feature request: Add redirectUrl query parameter support to `/service/logout` endpointPossibly taken A pull request linked to this issue is open or already merged. Openenhancement
Difficulty 3/5 1-2 days Newbie friendliness 42/100
-
Refine login API to get rid of cookies and automatic guestsPossibly taken @ryanrdoherty claimed this 686 days ago. Open
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
quelea-projection/Quelea#711 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ShaftHQ/SHAFT_ENGINE#6909 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
mudler/parakeet.cpp#99 ·
Maintainers usually reply within 1 day
-
[BUG] Re-subscribing the Mono returned by listTools/listResources/listResourceTemplates/listPrompts/listRoots duplicates the resultsPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
modelcontextprotocol/java-sdk#1174 · 1 reaction ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
baomidou/mybatis-plus#7185 ·