EventSystem does not clear m_CurrentInputModule when the active InputModule is disabled, causing Process() to continue executing

Open
#20 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Quiet
Tech stack
csharp
Domain
game-dev

Research direction

Start with BaseInputModule.OnDisable() and follow m_EventSystem.UpdateModules(), then compare the handling of m_SystemInputModules with m_CurrentInputModule during Process(). Reproduce disabling the active input module and determine the expected behavior; the issue is complete when the cause and desired fix are clearly documented or a focused change is specified.

Written by the indexing model from the issue text.

Description

BaseInputModule.OnDisable() calls m_EventSystem.UpdateModules(), which removes the module from m_SystemInputModules. However, m_CurrentInputModule is a separate reference that is never checked or cleared in this path.I just want to know why.

Dominant language
C#
Stars
1.6k
Forks
323
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Unity-Technologies/uGUI

All issues in Unity-Technologies/uGUI

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.