Make XXHash NOT internal

Open
#2,202 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
58/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Stale
Tech stack
csharp
Domain
networking

Research direction

Search the repository for the XXHash static class declaration and inspect its current access modifier. Make the requested visibility change, then verify that a custom external script can access XXHash without Netcode dependencies.

Written by the indexing model from the issue text.

Description

Tracking type:feature

Since its a static class without any Netcode dependencies, i really see no reason to make this class Internal.
I would like to do some custom hashing in my own scripts, but i can't access this class because it's internal (why?).

This is probably the simplest fix ever, you just need to remove one word : internal.

Thank you.

Dominant language
C#
Stars
2.3k
Forks
461
Avg merge
3d 16h
Merged PRs (30d)
20

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Unity-Technologies/com.unity.netcode.gameobjects

All issues in Unity-Technologies/com.unity.netcode.gameobjects

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.