NoiseBox addperiod/mulperiod copy paste issue?

Open
#17 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
48/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
cpp
Domain
audio-video-rtc

Research direction

Open NativeCode/Plugin_NoiseBox.cpp at line 110 and inspect the period comparison in context, including how addperiod and mulperiod are defined and used. Verify the intended comparison from the surrounding NoiseBox logic, then build or run the plugin's available checks. Done means the copy-paste condition uses the correct period value without changing unrelated behavior.

Written by the indexing model from the issue text.

Description

Instead of
[...] if (data->mulcount >= addperiod)

it should compare to 'mulperiod', right?
[...] if (data->mulcount >= mulperiod)

Source:
https://github.com/Unity-Technologies/NativeAudioPlugins/blob/188a776e2d9f217af1afa574b92a11cd82600271/NativeCode/Plugin_NoiseBox.cpp#L110C59-L110C68

Dominant language
C++
Stars
169
Forks
33
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Unity-Technologies/NativeAudioPlugins

All issues in Unity-Technologies/NativeAudioPlugins

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.