Incomplete FP support
@CaelmBleidd is already working on this.
Since Sep 5, 2022.
Assessment
This issue has not been assessed yet.
Description
For now, there are a few severe drawbacks in the FP implementation:
- Doesn't work float to double transformation and vise versa:
mkFp(someFloat, sort)andmkFp(someFloat.toDouble(), sortreturn different FP values sincetoDoublechanges the bits. We need to detect it somehow and make fp creation consistent. - There is no overload for fp creation from int value
- There are no tests for
mkFp(BV, BV, BV) - Multiple bugs in custom size FP: some combinations don't work, choose masks carefully for tests, add limits and checks in the constructors
- Operation implemented as part of the KFpValue:
isNaN,isInfinity,isNormal, etc. - Add support for the FP in Bitwuzla
- Replace
Longvalues in KFpDecl withBv - KFp128 should have
BVinstead of long values for its significand - Replace numbers with bit-vectors where it's possible (for example, in creation, in the internal storage, etc.)
- Additional tests for operations (along with extra methods, like
fpToFp) - Documentations for implemented classes and methods
- Dominant language
- Kotlin
- Stars
- 42
- Forks
- 17
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from UnitTestBot/ksmt
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
UnitTestBot/ksmt#164 · 1 reaction ·
-
Thread safetyOpenenhancement
Difficulty 4/5 3-5 days Newbie friendliness 35/100
UnitTestBot/ksmt#54 · 1 comment ·
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 25/100
UnitTestBot/ksmt#44 ·
All issues in UnitTestBot/ksmt
Similar issues
-
Source is down
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
keiyoushi/extensions-source#19491 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
MTES-MCT/rapportnav2#1557 ·
Maintainers usually reply within 1 day
-
ready-for-agent
Difficulty 1/5 1-3 hours Newbie friendliness 86/100
emm3000/Just-Chill#543 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
vaadin/intellij-plugin#600 ·
-
accessibility
Difficulty 2/5 1-3 hours Newbie friendliness 65/100