fix: customer site lists stop at 100 sites (BerlinDB default number)

Open
#2,136 5 comments 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@superdav42 is already working on this.

Since Nov 21, 2026.

  • #2139 by @superdav42 — open

Assessment

This issue has not been assessed yet.

Description

auto-dispatch bug origin:interactive status:in-review tier:standard

What

A customer with more than 100 sites cannot see or select the ones beyond the first 100 in the frontend account widgets. Customer::get_sites() passes no number, so BerlinDB applies its default of 100.

Evidence

The SQL the default call runs, captured with a query filter against the plugin's locked BerlinDB:

Call SQL limit
$customer->get_sites() LIMIT 100
$customer->get_sites(['number' => 0]) no LIMIT clause
$customer->get_sites(['number' => false]) no LIMIT clause
$customer->get_sites(['number' => -1]) LIMIT 1

vendor/berlindb/core/src/Database/Query.php:476 sets 'number' => 100.

Do not copy the 'number' => -1 convention used elsewhere in the plugin (for example inc/functions/customer.php:68) for this query. With Site::query() it returns a single site.

Callers that use the default:

  • inc/ui/class-account-summary-element.php:319: the site selector shown when no site is chosen. Sites past 100 cannot be selected.
  • inc/ui/class-my-sites-element.php:345: the My Sites list. Sites past 100 are not listed.
  • inc/ui/class-magic-link-url-element.php:354: picks the best candidate site; the cap matters less here.

This is not new. It was raised by a review bot on #2133, and My Sites has the same cap on main.

Files Scope

  • inc/ui/class-account-summary-element.php
  • inc/ui/class-my-sites-element.php
  • inc/models/class-customer.php

Decision to make

Rendering every site is fine for a selector but could be heavy for a very large customer. Either lift the limit for the selector only ('number' => 0), or paginate both lists. Keep the behaviour of customers with up to 100 sites unchanged.

Reference pattern

inc/models/class-customer.php:666 builds the query from $query_args, so get_sites(['number' => 0]) already works without changing the model.

Verification

  • Create 101 or more customer-owned sites for one customer (a short wp eval loop creating blogs and assigning them with wu_get_site()->set_customer_id()), then open the account page without a site selected and confirm all of them are selectable.
  • Log the SQL for the call and confirm there is no LIMIT 100.
  • With fewer than 100 sites, output is unchanged.

Tier

tier:standard. Files and evidence are known, but the all-versus-paginate choice is a design decision.


aidevops.sh v3.39.189 plugin for OpenCode

Dominant language
PHP
Stars
219
Forks
88
Avg merge
1d 7h
Merged PRs (30d)
58

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Ultimate-Multisite/ultimate-multisite

All issues in Ultimate-Multisite/ultimate-multisite

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.