fix: customer site lists stop at 100 sites (BerlinDB default number)
Maintainers usually reply within 1 day
Assessment
This issue has not been assessed yet.
Description
What
A customer with more than 100 sites cannot see or select the ones beyond the first 100 in the frontend account widgets. Customer::get_sites() passes no number, so BerlinDB applies its default of 100.
Evidence
The SQL the default call runs, captured with a query filter against the plugin's locked BerlinDB:
| Call | SQL limit |
|---|---|
$customer->get_sites() |
LIMIT 100 |
$customer->get_sites(['number' => 0]) |
no LIMIT clause |
$customer->get_sites(['number' => false]) |
no LIMIT clause |
$customer->get_sites(['number' => -1]) |
LIMIT 1 |
vendor/berlindb/core/src/Database/Query.php:476 sets 'number' => 100.
Do not copy the 'number' => -1 convention used elsewhere in the plugin (for example inc/functions/customer.php:68) for this query. With Site::query() it returns a single site.
Callers that use the default:
inc/ui/class-account-summary-element.php:319: the site selector shown when no site is chosen. Sites past 100 cannot be selected.inc/ui/class-my-sites-element.php:345: the My Sites list. Sites past 100 are not listed.inc/ui/class-magic-link-url-element.php:354: picks the best candidate site; the cap matters less here.
This is not new. It was raised by a review bot on #2133, and My Sites has the same cap on main.
Files Scope
inc/ui/class-account-summary-element.phpinc/ui/class-my-sites-element.phpinc/models/class-customer.php
Decision to make
Rendering every site is fine for a selector but could be heavy for a very large customer. Either lift the limit for the selector only ('number' => 0), or paginate both lists. Keep the behaviour of customers with up to 100 sites unchanged.
Reference pattern
inc/models/class-customer.php:666 builds the query from $query_args, so get_sites(['number' => 0]) already works without changing the model.
Verification
- Create 101 or more customer-owned sites for one customer (a short
wp evalloop creating blogs and assigning them withwu_get_site()->set_customer_id()), then open the account page without a site selected and confirm all of them are selectable. - Log the SQL for the call and confirm there is no
LIMIT 100. - With fewer than 100 sites, output is unchanged.
Tier
tier:standard. Files and evidence are known, but the all-versus-paginate choice is a design decision.
aidevops.sh v3.39.189 plugin for OpenCode
- Dominant language
- PHP
- Stars
- 219
- Forks
- 88
- Avg merge
- 1d 7h
- Merged PRs (30d)
- 58
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Ultimate-Multisite/ultimate-multisite
-
bug origin:interactive status:available
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Ultimate-Multisite/ultimate-multisite#2131 ·
Maintainers usually reply within 1 day
-
bug hold-for-review no-auto-dispatch origin:interactive status:available
Difficulty 3/5 1-2 days Newbie friendliness 20/100
Ultimate-Multisite/ultimate-multisite#2140 ·
Maintainers usually reply within 1 day
-
enhancement hold-for-review no-auto-dispatch origin:interactive status:available
Difficulty 5/5 Over a week Newbie friendliness 15/100
Ultimate-Multisite/ultimate-multisite#2137 ·
Maintainers usually reply within 1 day
-
fix: My Sites, Limits and Current Membership columns above 3 collapse to one column (missing grid utilities)Possibly taken @superdav42 claimed this today. Openauto-dispatch bug origin:interactive status:in-review tier:standard
Ultimate-Multisite/ultimate-multisite#2134 · 5 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
security(sso): apply mapped-domain token policy to admin-bar magic linksPossibly taken @superdav42 claimed this 1 day ago. Openauto-dispatch origin:interactive status:in-review tier:standard
Ultimate-Multisite/ultimate-multisite#2125 · 5 comments · 1 assignee ·
Maintainers usually reply within 1 day
All issues in Ultimate-Multisite/ultimate-multisite
Similar issues
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
quantum-php/framework#692 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
ajeetraina/awesome-docker-sbx#559 ·
-
dependencies enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
novalo-dev/Prestashop-MCP-Server#329 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
sync-en
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day