Add tests for untested PinfoldStorage write methods
Maintainers usually reply within 1 day
@dharamdan01 is already working on this.
Since Nov 2, 2026.
Assessment
This issue has not been assessed yet.
Description
Problem
Several PinfoldStorage write methods have no tests, including the one that does imports and a migration edge case. A regression in them could silently lose or reorder saved tabs.
Where to look
utils/storage.js:334-347,importGroups:mergeputs imported groups first;replaceoverwrites.utils/storage.js:284-301,updateTabTitle: also renames a titled single-tab group; returnsfalsefor an unknown group or tab.utils/storage.js:449-458,assignGroupToFolder: a falsyfolderIdbecomesnull.utils/storage.js:460-462,clearAllData: removes groups and folders but should keep settings.utils/storage.js:467-492,migrateLegacyStorage: when onlytabi_statsexists, it removes that key and returnsfalse.tests/storage.test.js:9-47(installChromeMock,store.load/store.dump),:92-98(seedGroup).
Suggested approach
- Add one
test(...)per behavior totests/storage.test.js, reusingseedGroupandstore.dump(). - Only add tests. If one shows a bug, report it in a new issue.
Done when
- Each method or case listed above has at least one assertion.
npm testpasses.
New to Pinfold? See CONTRIBUTING.md for setup and tests. Please comment here to claim this issue before you start, and wait to be assigned, so two people don't do the same work. Good first issues are meant for newcomers, so please take one at a time.
- Dominant language
- JavaScript
- Stars
- 1
- Forks
- 2
- Avg merge
- 9h 33m
- Merged PRs (30d)
- 29
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Tektrix/pinfold
-
good first issue tests
Difficulty 1/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Add a "Copy links" action to each tab groupPossibly taken @Vishnu-vkn claimed this today. Openenhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Tektrix/pinfold#43 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 48/100
Maintainers usually reply within 1 day
-
Add tests for the service worker's restoreTabsMay be free again @Vamsi-2581 claimed this 12 days ago, and no pull request is open. Opengood first issue tests
Difficulty 3/5 1-2 days Newbie friendliness 70/100
Tektrix/pinfold#30 · 2 comments ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
eliasstravik/herdr-projects#1032 ·
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
1️⃣ phase/under-investigation flaky/confirmed flaky/needs-decision type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
growilabs/growi#12246 · 3 comments ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
TMHSDigital/Free-Game-Dev-Assets#301 ·
Maintainers usually reply within 1 day